Bug 108882 - [Mac] Captions menu should indicate language and type of track
Summary: [Mac] Captions menu should indicate language and type of track
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-02-04 17:25 PST by Dean Jackson
Modified: 2013-02-05 00:05 PST (History)
9 users (show)

See Also:


Attachments
Patch (32.42 KB, patch)
2013-02-04 17:51 PST, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (32.40 KB, patch)
2013-02-04 19:10 PST, Dean Jackson
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-02-04 17:25:17 PST
For Mac, we want a specific text label on the menu items in the list of captions. For example:

<label> <language> <type-indicator>
Comment 1 Radar WebKit Bug Importer 2013-02-04 17:25:40 PST
<rdar://problem/13149502>
Comment 2 Dean Jackson 2013-02-04 17:51:55 PST
Created attachment 186510 [details]
Patch
Comment 3 Build Bot 2013-02-04 18:00:48 PST
Comment on attachment 186510 [details]
Patch

Attachment 186510 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16365575
Comment 4 Dean Jackson 2013-02-04 18:18:57 PST
Gah - build failure because it relies on r141840 which only just landed.
Comment 5 Dean Jackson 2013-02-04 18:19:18 PST
Anyway, I developed on mac-wk2 so I think it's ok there.
Comment 6 EFL EWS Bot 2013-02-04 18:43:27 PST
Comment on attachment 186510 [details]
Patch

Attachment 186510 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16376433
Comment 7 WebKit Review Bot 2013-02-04 18:48:00 PST
Comment on attachment 186510 [details]
Patch

Attachment 186510 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16376437
Comment 8 Peter Beverloo (cr-android ews) 2013-02-04 19:04:36 PST
Comment on attachment 186510 [details]
Patch

Attachment 186510 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16365604
Comment 9 Dean Jackson 2013-02-04 19:10:32 PST
Created attachment 186525 [details]
Patch
Comment 10 Eric Carlson 2013-02-04 20:51:50 PST
Comment on attachment 186525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186525&action=review

> Source/WebCore/page/CaptionUserPreferencesMac.mm:439
> +    if (track->kind() != track->subtitlesKeyword()) {

Shouldn't this test to see if it *is* a caption track instead?
Comment 11 Dean Jackson 2013-02-05 00:04:07 PST
Comment on attachment 186525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186525&action=review

>> Source/WebCore/page/CaptionUserPreferencesMac.mm:439
>> +    if (track->kind() != track->subtitlesKeyword()) {
> 
> Shouldn't this test to see if it *is* a caption track instead?

Yes. Fixed.
Comment 12 Dean Jackson 2013-02-05 00:05:35 PST
Committed r141864: <http://trac.webkit.org/changeset/141864>