RESOLVED FIXED 108882
[Mac] Captions menu should indicate language and type of track 
https://bugs.webkit.org/show_bug.cgi?id=108882
Summary [Mac] Captions menu should indicate language and type of track
Dean Jackson
Reported 2013-02-04 17:25:17 PST
For Mac, we want a specific text label on the menu items in the list of captions. For example: <label> <language> <type-indicator>
Attachments
Patch (32.42 KB, patch)
2013-02-04 17:51 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (32.40 KB, patch)
2013-02-04 19:10 PST, Dean Jackson 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-02-04 17:25:40 PST
<rdar://problem/13149502>
Dean Jackson
Comment 2 2013-02-04 17:51:55 PST
Created attachment 186510 [details] Patch
Build Bot
Comment 3 2013-02-04 18:00:48 PST
Comment on attachment 186510 [details] Patch Attachment 186510 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16365575
Dean Jackson
Comment 4 2013-02-04 18:18:57 PST
Gah - build failure because it relies on r141840 which only just landed.
Dean Jackson
Comment 5 2013-02-04 18:19:18 PST
Anyway, I developed on mac-wk2 so I think it's ok there.
EFL EWS Bot
Comment 6 2013-02-04 18:43:27 PST
Comment on attachment 186510 [details] Patch Attachment 186510 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16376433
WebKit Review Bot
Comment 7 2013-02-04 18:48:00 PST
Comment on attachment 186510 [details] Patch Attachment 186510 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16376437
Peter Beverloo (cr-android ews)
Comment 8 2013-02-04 19:04:36 PST
Comment on attachment 186510 [details] Patch Attachment 186510 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16365604
Dean Jackson
Comment 9 2013-02-04 19:10:32 PST
Created attachment 186525 [details] Patch
Eric Carlson
Comment 10 2013-02-04 20:51:50 PST
Comment on attachment 186525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186525&action=review > Source/WebCore/page/CaptionUserPreferencesMac.mm:439 > + if (track->kind() != track->subtitlesKeyword()) { Shouldn't this test to see if it *is* a caption track instead?
Dean Jackson
Comment 11 2013-02-05 00:04:07 PST
Comment on attachment 186525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186525&action=review >> Source/WebCore/page/CaptionUserPreferencesMac.mm:439 >> + if (track->kind() != track->subtitlesKeyword()) { > > Shouldn't this test to see if it *is* a caption track instead? Yes. Fixed.
Dean Jackson
Comment 12 2013-02-05 00:05:35 PST
Committed r141864: <http://trac.webkit.org/changeset/141864>
Note You need to log in before you can comment on or make changes to this bug.