Bug 108871 - Move HTMLShadowElement code behind SHADOW_DOM flag.
Summary: Move HTMLShadowElement code behind SHADOW_DOM flag.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-04 15:35 PST by Changhun Kang
Modified: 2020-08-18 10:43 PDT (History)
11 users (show)

See Also:

Attachments
Patch (2.11 KB, patch)
2013-02-04 15:41 PST, Changhun Kang 		chkang514: review-
chkang514: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Changhun Kang 2013-02-04 15:35:12 PST 
According to Bug 103339(https://bugs.webkit.org/show_bug.cgi?id=103339),
 I hide #include "HTMLShadowElement.h".
Comment 1 Changhun Kang 2013-02-04 15:41:35 PST 
Created attachment 186481 [details]
Patch
Comment 2 Kent Tamura 2013-02-04 17:15:37 PST 
Comment on attachment 186481 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186481&action=review

> Source/WebCore/dom/NodeRenderingContext.cpp:38
> +#if ENABLE(SHADOW_DOM)
>  #include "HTMLShadowElement.h"
> +#endif

Why do you want to do this?
I don't think we need to do it because the content of HTMLShadowElement.h is already wrapped with ENABEL(SHADOW_DOM).
Comment 3 Changhun Kang 2013-02-07 02:20:02 PST 
(In reply to comment #2)
> (From update of attachment 186481 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186481&action=review
> 
> > Source/WebCore/dom/NodeRenderingContext.cpp:38
> > +#if ENABLE(SHADOW_DOM)
> >  #include "HTMLShadowElement.h"
> > +#endif
> 
> Why do you want to do this?
> I don't think we need to do it because the content of HTMLShadowElement.h is already wrapped with ENABEL(SHADOW_DOM).

I agree with your opinion.
Thanks for your advice.
I close this bug.
Comment 4 Ryosuke Niwa 2020-08-18 10:43:08 PDT 
This code is gone.