RESOLVED FIXED 108856
Allow TextTracks to be marked as closed captions 
https://bugs.webkit.org/show_bug.cgi?id=108856
Summary Allow TextTracks to be marked as closed captions
Dean Jackson
Reported 2013-02-04 13:56:32 PST
While this isn't exposed directly in markup, some platform media frameworks can provide indication that a caption track is a closed caption. Expose such a flag on TextTrack and platforms can show a different UI if they want to.
Attachments
Patch (2.48 KB, patch)
2013-02-04 14:00 PST, Dean Jackson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-02-04 13:56:53 PST
<rdar://problem/13147063>
Dean Jackson
Comment 2 2013-02-04 14:00:28 PST
Created attachment 186455 [details] Patch
Darin Adler
Comment 3 2013-02-04 14:14:44 PST
Comment on attachment 186455 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186455&action=review A little strange to land just the patch that adds the data, but OK if you will follow up soon. > Source/WebCore/html/track/TextTrack.cpp:110 > + , m_closedCaption(false) Should be named m_isClosedCaption. > Source/WebCore/html/track/TextTrack.h:113 > + void setIsClosedCaption(bool c) { m_closedCaption = c; } I’d name the local variable “isClosedCaption” rather than c.
Dean Jackson
Comment 4 2013-02-04 18:03:29 PST
Committed r141840: <http://trac.webkit.org/changeset/141840>
Note You need to log in before you can comment on or make changes to this bug.