Bug 108856 - Allow TextTracks to be marked as closed captions
Summary: Allow TextTracks to be marked as closed captions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-02-04 13:56 PST by Dean Jackson
Modified: 2013-02-04 18:03 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.48 KB, patch)
2013-02-04 14:00 PST, Dean Jackson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-02-04 13:56:32 PST 
While this isn't exposed directly in markup, some platform media frameworks can provide indication that a caption track is a closed caption. Expose such a flag on TextTrack and platforms can show a different UI if they want to.
Comment 1 Radar WebKit Bug Importer 2013-02-04 13:56:53 PST 
<rdar://problem/13147063>
Comment 2 Dean Jackson 2013-02-04 14:00:28 PST 
Created attachment 186455 [details]
Patch
Comment 3 Darin Adler 2013-02-04 14:14:44 PST 
Comment on attachment 186455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186455&action=review

A little strange to land just the patch that adds the data, but OK if you will follow up soon.

> Source/WebCore/html/track/TextTrack.cpp:110
> +    , m_closedCaption(false)

Should be named m_isClosedCaption.

> Source/WebCore/html/track/TextTrack.h:113
> +    void setIsClosedCaption(bool c) { m_closedCaption = c; }

I’d name the local variable “isClosedCaption” rather than c.
Comment 4 Dean Jackson 2013-02-04 18:03:29 PST 
Committed r141840: <http://trac.webkit.org/changeset/141840>