Bug 108846 - Web Inspector: Test bad options to evaluate and ensure the errors are returned
Summary: Web Inspector: Test bad options to evaluate and ensure the errors are returned
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 106811
  Show dependency tree / graph
 
Reported: 2013-02-04 12:15 PST by johnjbarton
Modified: 2014-12-13 13:47 PST (History)
12 users (show)

See Also:

Attachments
Patch (5.25 KB, patch)
2013-02-04 12:28 PST, johnjbarton 		vsevik: review-
buildbot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description johnjbarton 2013-02-04 12:15:42 PST 
The current tests do not test for the case where useContentScriptContext is set true by the developer but there is no security origin matching content script context.

When such a test is added, it becomes apparent that the error for option processing are not returned to the client of evaluate().

Patch ready
Comment 1 johnjbarton 2013-02-04 12:16:38 PST 
The bad-option test on the patch for bug 106811 cannot pass without a fix to this bug.
Comment 2 johnjbarton 2013-02-04 12:28:54 PST 
Created attachment 186436 [details]
Patch
Comment 3 Build Bot 2013-02-04 14:03:03 PST 
Comment on attachment 186436 [details]
Patch

Attachment 186436 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16365456

New failing tests:
inspector/extensions/extensions-eval-content-script-bad-option.html
Comment 4 Build Bot 2013-02-04 16:42:23 PST 
Comment on attachment 186436 [details]
Patch

Attachment 186436 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16366508

New failing tests:
inspector/extensions/extensions-eval-content-script-bad-option.html
Comment 5 Build Bot 2013-02-04 16:47:23 PST 
Comment on attachment 186436 [details]
Patch

Attachment 186436 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16366511

New failing tests:
inspector/extensions/extensions-eval-content-script-bad-option.html
Comment 6 Andrey Kosyakov 2013-02-11 01:51:07 PST 
Comment on attachment 186436 [details]
Patch

I don't think we should invoke the callback wrapper passing it the text error message. Besides, returning value from the message handler already results in dispatching the error to the client. See also bug 108640.
Comment 7 Vsevolod Vlasov 2013-02-11 01:52:51 PST 
Comment on attachment 186436 [details]
Patch

r- per Andrey's comment.