Bug 108842 – Add specific EditActions for Bold and Italic commands.

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Enrica Casucci]

On iOS we need specific EditActions for Bold, Italic, etc. in order to display the correct message when shaking to undo.

[Enrica Casucci]

I discovered that all platforms have a separate edit action for underline and not for bold and italic.
I believe it is better to change it for all platforms.

[Enrica Casucci]

Created attachment 186433 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 186433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186433&action=review

r=me provided it builds everywhere.

> Source/WebCore/ChangeLog:9
> +        No new tests. No behavior change.

We should explain why we're making this change.

> Source/WebKit2/ChangeLog:21
> [phone]  Enrica Casucci  <[e-mail]>
> +
> +        Add iOS specific EditActions.
> +        https://bugs.webkit.org/show_bug.cgi?id=108842.
> +        <rdar://problem/13098252>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * UIProcess/WebEditCommandProxy.cpp:
> +        (WebKit::WebEditCommandProxy::nameForEditAction):

Double change logs.

[Enrica Casucci]

(In reply to comment #3)
> (From update of attachment 186433 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186433&action=review
> 
> r=me provided it builds everywhere.
> 
> > Source/WebCore/ChangeLog:9
> > +        No new tests. No behavior change.
> 
> We should explain why we're making this change.
I will add some explanation.
> 
> > Source/WebKit2/ChangeLog:21
> > [phone]  Enrica Casucci  <[e-mail]>
> > +
> > +        Add iOS specific EditActions.
> > +        https://bugs.webkit.org/show_bug.cgi?id=108842.
> > +        <rdar://problem/13098252>
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        * UIProcess/WebEditCommandProxy.cpp:
> > +        (WebKit::WebEditCommandProxy::nameForEditAction):
> 
> Double change logs.
Will fix it.

Thanks for the review!

[Enrica Casucci]

Committed revision 141799.