Bug 108842 - Add specific EditActions for Bold and Italic commands.
Summary: Add specific EditActions for Bold and Italic commands.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-02-04 11:04 PST by Enrica Casucci
Modified: 2013-02-04 13:23 PST (History)
2 users (show)

See Also:

Attachments
Patch (9.26 KB, patch)
2013-02-04 12:22 PST, Enrica Casucci 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2013-02-04 11:04:19 PST 
On iOS we need specific EditActions for Bold, Italic, etc. in order to display the correct message when shaking to undo.
Comment 1 Enrica Casucci 2013-02-04 12:06:17 PST 
I discovered that all platforms have a separate edit action for underline and not for bold and italic.
I believe it is better to change it for all platforms.
Comment 2 Enrica Casucci 2013-02-04 12:22:49 PST 
Created attachment 186433 [details]
Patch
Comment 3 Ryosuke Niwa 2013-02-04 12:25:51 PST 
Comment on attachment 186433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186433&action=review

r=me provided it builds everywhere.

> Source/WebCore/ChangeLog:9
> +        No new tests. No behavior change.

We should explain why we're making this change.

> Source/WebKit2/ChangeLog:21
> +2013-02-04  Enrica Casucci  <enrica@apple.com>
> +
> +        Add iOS specific EditActions.
> +        https://bugs.webkit.org/show_bug.cgi?id=108842.
> +        <rdar://problem/13098252>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * UIProcess/WebEditCommandProxy.cpp:
> +        (WebKit::WebEditCommandProxy::nameForEditAction):

Double change logs.
Comment 4 Enrica Casucci 2013-02-04 13:13:46 PST 
(In reply to comment #3)
> (From update of attachment 186433 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186433&action=review
> 
> r=me provided it builds everywhere.
> 
> > Source/WebCore/ChangeLog:9
> > +        No new tests. No behavior change.
> 
> We should explain why we're making this change.
I will add some explanation.
> 
> > Source/WebKit2/ChangeLog:21
> > +2013-02-04  Enrica Casucci  <enrica@apple.com>
> > +
> > +        Add iOS specific EditActions.
> > +        https://bugs.webkit.org/show_bug.cgi?id=108842.
> > +        <rdar://problem/13098252>
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        * UIProcess/WebEditCommandProxy.cpp:
> > +        (WebKit::WebEditCommandProxy::nameForEditAction):
> 
> Double change logs.
Will fix it.

Thanks for the review!
Comment 5 Enrica Casucci 2013-02-04 13:23:41 PST 
Committed revision 141799.