Bug 108823 – Web Inspector: forced pseudo classes aren't cleared from inspected page when Inspector closes

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Antoine Quint]

Steps to reproduce:

1. Open http://nightly.webkit.org/start
2. Cmd+click on the "report issues" link in the paragraph under "How can I help?"
3. Pick Inspect Element from context menu
4. Force :hover CSS pseudo-class onto element using the "Force Element State" contextual menu on the matching DOM node in the inspector
5. Close the inspector

At this stage, I'd expect the forced :hover pseudo-class to have been removed. Reopening and reclosing the Web Inspector eventually resets the forced pseudo-classes.

[Radar WebKit Bug Importer]

<rdar://problem/13143550>

[Joseph Pecoraro]

The CSSAgent tries to reset forced pseudo states in InspectorCSSAgent::resetPseudoStates except it uses the DOM Agent which may have cleared state already. Lets avoid using the DOM Agent here during cleanup. Using the DOM Agent at other places also seems like it could be incorrect (InspectorCSSAgent::didRemoveDOMNode) or potentially incomplete (InspectorCSSAgent::didRemoveDocument). So I'll just clean all this up.

[Joseph Pecoraro]

Created attachment 297990 [details]
[PATCH] Proposed Fix

I might be able to write a test for this.

[Blaze Burg]

Comment on attachment 297990 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=297990&action=review

> Source/WebCore/inspector/InspectorCSSAgent.cpp:414
> +    m_documentsWithForcedPsuedoStates.remove(&document);

If it's not too much work, please fix the spelling of this member.

[Joseph Pecoraro]

<https://trac.webkit.org/changeset/210316>