Bug 108818 - [v8] explicit isolate parameter for MakeWeak calls
Summary: [v8] explicit isolate parameter for MakeWeak calls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-04 05:22 PST by Dan Carney
Modified: 2013-02-04 07:58 PST (History)
4 users (show)

See Also:


Attachments
Patch (25.18 KB, patch)
2013-02-04 05:24 PST, Dan Carney
no flags Details | Formatted Diff | Diff
Patch (25.19 KB, patch)
2013-02-04 05:49 PST, Dan Carney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Carney 2013-02-04 05:22:38 PST
[v8] explicit isolate parameter for MakeWeak calls
Comment 1 Dan Carney 2013-02-04 05:24:40 PST
Created attachment 186357 [details]
Patch
Comment 2 Kentaro Hara 2013-02-04 05:40:41 PST
Comment on attachment 186357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186357&action=review

> Source/WebCore/bindings/v8/DOMDataStore.cpp:43
> +    , m_wrapperMap(v8::Isolate::GetCurrent()) // TODO Don't call GetCurrent twice.

TODO => FIXME

> Source/WebCore/bindings/v8/DOMWrapperMap.h:108
> +    v8::NearDeathCallback m_callback;

NearDeathCallback is a good name!
Comment 3 Kentaro Hara 2013-02-04 05:41:06 PST
View in context: https://bugs.webkit.org/attachment.cgi?id=186357&action=review

> Source/WebCore/bindings/v8/DOMDataStore.cpp:43
> +    , m_wrapperMap(v8::Isolate::GetCurrent()) // TODO Don't call GetCurrent twice.

TODO => FIXME

> Source/WebCore/bindings/v8/DOMWrapperMap.h:108
> +    v8::NearDeathCallback m_callback;

NearDeathCallback is a good name!
Comment 4 Dan Carney 2013-02-04 05:49:25 PST
Created attachment 186360 [details]
Patch
Comment 5 Dan Carney 2013-02-04 05:49:56 PST
Comment on attachment 186360 [details]
Patch

addressed TODO => FIXME issue
Comment 6 WebKit Review Bot 2013-02-04 07:58:28 PST
Comment on attachment 186360 [details]
Patch

Clearing flags on attachment: 186360

Committed r141771: <http://trac.webkit.org/changeset/141771>
Comment 7 WebKit Review Bot 2013-02-04 07:58:31 PST
All reviewed patches have been landed.  Closing bug.