Bug 108807 - Coordinated Graphics : disconnectCustomFilterProgram does not do anything.
Summary: Coordinated Graphics : disconnectCustomFilterProgram does not do anything.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-04 03:13 PST by Gwang Yoon Hwang
Modified: 2013-02-04 20:46 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.92 KB, patch)
2013-02-04 03:16 PST, Gwang Yoon Hwang
no flags Details | Formatted Diff | Diff
Patch (1.93 KB, patch)
2013-02-04 14:51 PST, Gwang Yoon Hwang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gwang Yoon Hwang 2013-02-04 03:13:45 PST
Coordinated Graphics : disconnectCustomFilterProgram does not do anything.
Comment 1 Gwang Yoon Hwang 2013-02-04 03:16:34 PST
Created attachment 186333 [details]
Patch
Comment 2 Noam Rosenthal 2013-02-04 14:49:08 PST
Comment on attachment 186333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186333&action=review

LGTM, needs WK2 owner to review.

> Source/WebKit2/ChangeLog:9
> +        disconnect when CoordinatedLayerTreeHost destructed.

destructed -> gets destructed.
Comment 3 Gwang Yoon Hwang 2013-02-04 14:51:56 PST
Created attachment 186465 [details]
Patch
Comment 4 Gwang Yoon Hwang 2013-02-04 14:53:21 PST
(In reply to comment #2)
> (From update of attachment 186333 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186333&action=review
> 
> LGTM, needs WK2 owner to review.
> 
> > Source/WebKit2/ChangeLog:9
> > +        disconnect when CoordinatedLayerTreeHost destructed.
> 
> destructed -> gets destructed.

Thanks. I fixed the sentence.
Comment 5 WebKit Review Bot 2013-02-04 20:46:36 PST
Comment on attachment 186465 [details]
Patch

Clearing flags on attachment: 186465

Committed r141853: <http://trac.webkit.org/changeset/141853>
Comment 6 WebKit Review Bot 2013-02-04 20:46:39 PST
All reviewed patches have been landed.  Closing bug.