Bug 108791 – Support setLangAttributeAwareFormControlUIEnabled on Chromium Windows XP

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Kent Tamura]

Support setLangAttributeAwareFormControlUIEnabled on Chromium Windows

[Kent Tamura]

Created attachment 186307 [details]
Patch

[Kentaro Hara]

Comment on attachment 186307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186307&action=review

> Source/WebCore/platform/text/win/LocaleWin.cpp:71
> +static void initializeNameToLCIDMapIfEmpty(NameToLCIDMap& map)

ensureNameToLCIDMap() ? (I'm not sure of naming convention around here though.)

> Source/WebCore/platform/text/win/LocaleWin.cpp:108
> +    if (!name || !name[0])

Is it safe to access name[0] without checking name.length ?

> Source/WebCore/platform/text/win/LocaleWin.cpp:136
> -        return LOCALE_USER_DEFAULT;
> +        localeNameToLCID = convertLocaleNameToLCID;

Is it OK to fall through the code when localeNameToLCID is LOCALE_USER_DEFAULT ?

[Kent Tamura]

Comment on attachment 186307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186307&action=review

>> Source/WebCore/platform/text/win/LocaleWin.cpp:108
>> +    if (!name || !name[0])
> 
> Is it safe to access name[0] without checking name.length ?

Yes, it is.  We have no ways to check length of 'name' because it is null-terminated string.

>> Source/WebCore/platform/text/win/LocaleWin.cpp:136
>> +        localeNameToLCID = convertLocaleNameToLCID;
> 
> Is it OK to fall through the code when localeNameToLCID is LOCALE_USER_DEFAULT ?

Yes. localeNameToLCID is a function pointer, and convertLocaleNameToLCID and LocaleNameToLCID are compatible.

[Kentaro Hara]

Comment on attachment 186307 [details]
Patch

thanks for clarification!

[Kent Tamura]

Committed r141741: <http://trac.webkit.org/changeset/141741>