Bug 108784 – Fix build warning after r141648

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[KwangYong Choi]

/home/cky/open-source/WebKit/Source/WebKit2/UIProcess/Storage/StorageManager.cpp:52:6: warning: unused parameter ‘storageAreaID’ [-Wunused-parameter]
/home/cky/open-source/WebKit/Source/WebKit2/UIProcess/Storage/StorageManager.cpp:52:6: warning: unused parameter ‘storageNamespaceID’ [-Wunused-parameter]
/home/cky/open-source/WebKit/Source/WebKit2/UIProcess/Storage/StorageManager.cpp:56:6: warning: unused parameter ‘storageAreaID’ [-Wunused-parameter]

[KwangYong Choi]

Created attachment 186286 [details]
Patch

[Kentaro Hara]

Comment on attachment 186286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186286&action=review

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:52
> -void StorageManager::createStorageArea(CoreIPC::Connection*, uint64_t storageAreaID, uint64_t storageNamespaceID, const SecurityOriginData&)
> +void StorageManager::createStorageArea(CoreIPC::Connection*, uint64_t, uint64_t, const SecurityOriginData&)

You might want to use 'uint64_t /* storageAreaID */, uint64_t /* storageNamespaceID */', because otherwise you cannot distinguish two parameters.

[KwangYong Choi]

Comment on attachment 186286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186286&action=review

>> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:52
>> +void StorageManager::createStorageArea(CoreIPC::Connection*, uint64_t, uint64_t, const SecurityOriginData&)
> 
> You might want to use 'uint64_t /* storageAreaID */, uint64_t /* storageNamespaceID */', because otherwise you cannot distinguish two parameters.

Ok I will change.

[KwangYong Choi]

Created attachment 186288 [details]
Patch

[Kentaro Hara]

Comment on attachment 186288 [details]
Patch

thanks

[WebKit Review Bot]

Comment on attachment 186288 [details]
Patch

Clearing flags on attachment: 186288

Committed r141732: <http://trac.webkit.org/changeset/141732>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Anders Carlsson]

(In reply to comment #5)
> (From update of attachment 186288 [details])
> thanks

Kentaro, this is a WebKit2 patch and needs to be reviewed by a WebKit2 owner. This is not the right fix either. The right fix is to use UNUSED_PARAM.

[Kentaro Hara]

(In reply to comment #8)
> Kentaro, this is a WebKit2 patch and needs to be reviewed by a WebKit2 owner. This is not the right fix either. The right fix is to use UNUSED_PARAM.

I'm sorry. I'll be careful.

I think that was a right fix. We use UNUSED_PARAM only when a parameter is in an #if macro. (Please look at this discussion: http://markmail.org/message/jv3ncbuhropkkzoq )