Bug 108784 - Fix build warning after r141648
Summary: Fix build warning after r141648
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: KwangYong Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-03 18:25 PST by KwangYong Choi
Modified: 2013-02-04 16:10 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.53 KB, patch)
2013-02-03 18:29 PST, KwangYong Choi
no flags Details | Formatted Diff | Diff
Patch (1.57 KB, patch)
2013-02-03 19:32 PST, KwangYong Choi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KwangYong Choi 2013-02-03 18:25:20 PST
/home/cky/open-source/WebKit/Source/WebKit2/UIProcess/Storage/StorageManager.cpp:52:6: warning: unused parameter ‘storageAreaID’ [-Wunused-parameter]
/home/cky/open-source/WebKit/Source/WebKit2/UIProcess/Storage/StorageManager.cpp:52:6: warning: unused parameter ‘storageNamespaceID’ [-Wunused-parameter]
/home/cky/open-source/WebKit/Source/WebKit2/UIProcess/Storage/StorageManager.cpp:56:6: warning: unused parameter ‘storageAreaID’ [-Wunused-parameter]
Comment 1 KwangYong Choi 2013-02-03 18:29:23 PST
Created attachment 186286 [details]
Patch
Comment 2 Kentaro Hara 2013-02-03 18:34:43 PST
Comment on attachment 186286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186286&action=review

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:52
> -void StorageManager::createStorageArea(CoreIPC::Connection*, uint64_t storageAreaID, uint64_t storageNamespaceID, const SecurityOriginData&)
> +void StorageManager::createStorageArea(CoreIPC::Connection*, uint64_t, uint64_t, const SecurityOriginData&)

You might want to use 'uint64_t /* storageAreaID */, uint64_t /* storageNamespaceID */', because otherwise you cannot distinguish two parameters.
Comment 3 KwangYong Choi 2013-02-03 18:39:16 PST
Comment on attachment 186286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186286&action=review

>> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:52
>> +void StorageManager::createStorageArea(CoreIPC::Connection*, uint64_t, uint64_t, const SecurityOriginData&)
> 
> You might want to use 'uint64_t /* storageAreaID */, uint64_t /* storageNamespaceID */', because otherwise you cannot distinguish two parameters.

Ok I will change.
Comment 4 KwangYong Choi 2013-02-03 19:32:28 PST
Created attachment 186288 [details]
Patch
Comment 5 Kentaro Hara 2013-02-03 19:33:00 PST
Comment on attachment 186288 [details]
Patch

thanks
Comment 6 WebKit Review Bot 2013-02-03 20:27:20 PST
Comment on attachment 186288 [details]
Patch

Clearing flags on attachment: 186288

Committed r141732: <http://trac.webkit.org/changeset/141732>
Comment 7 WebKit Review Bot 2013-02-03 20:27:25 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Anders Carlsson 2013-02-04 10:14:32 PST
(In reply to comment #5)
> (From update of attachment 186288 [details])
> thanks

Kentaro, this is a WebKit2 patch and needs to be reviewed by a WebKit2 owner. This is not the right fix either. The right fix is to use UNUSED_PARAM.
Comment 9 Kentaro Hara 2013-02-04 16:10:58 PST
(In reply to comment #8)
> Kentaro, this is a WebKit2 patch and needs to be reviewed by a WebKit2 owner. This is not the right fix either. The right fix is to use UNUSED_PARAM.

I'm sorry. I'll be careful.

I think that was a right fix. We use UNUSED_PARAM only when a parameter is in an #if macro. (Please look at this discussion: http://markmail.org/message/jv3ncbuhropkkzoq )