RESOLVED FIXED 108783
Update CaptionUserPreferences 
https://bugs.webkit.org/show_bug.cgi?id=108783
Summary Update CaptionUserPreferences
Eric Carlson
Reported 2013-02-03 18:12:40 PST
The system code used to allow the Mac port to modify caption and subtitle style has changed, update for it.
Attachments
Proposed patch (29.76 KB, patch)
2013-02-03 20:44 PST, Eric Carlson 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Update patch for my good friend the style bot. (29.61 KB, patch)
2013-02-03 21:13 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Another update. (30.20 KB, patch)
2013-02-03 21:24 PST, Eric Carlson 		buildbot: commit-queue-
DetailsFormatted DiffDiff
One more time... (30.43 KB, patch)
2013-02-03 22:13 PST, Eric Carlson 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Another update. (30.42 KB, patch)
2013-02-04 07:44 PST, Eric Carlson 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Updated patch (32.99 KB, patch)
2013-02-04 11:12 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2013-02-03 20:44:12 PST
Created attachment 186294 [details] Proposed patch
WebKit Review Bot
Comment 2 2013-02-03 20:47:23 PST
Attachment 186294 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/CaptionUserPreferences.h', u'Source/WebCore/page/CaptionUserPreferencesMac.h', u'Source/WebCore/page/CaptionUserPreferencesMac.mm', u'Source/WebCore/platform/Language.cpp', u'Source/WebCore/platform/Language.h', u'Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm']" exit_code: 1 Source/WebCore/page/CaptionUserPreferences.h:52: Too many spaces inside { }. [whitespace/braces] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2013-02-03 21:11:56 PST
Comment on attachment 186294 [details] Proposed patch Attachment 186294 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16365119
Eric Carlson
Comment 4 2013-02-03 21:13:17 PST
Created attachment 186296 [details] Update patch for my good friend the style bot.
Eric Carlson
Comment 5 2013-02-03 21:24:43 PST
Created attachment 186298 [details] Another update.
Build Bot
Comment 6 2013-02-03 21:54:03 PST
Comment on attachment 186298 [details] Another update. Attachment 186298 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16371034
Eric Carlson
Comment 7 2013-02-03 22:13:38 PST
Created attachment 186304 [details] One more time...
Build Bot
Comment 8 2013-02-03 22:42:33 PST
Comment on attachment 186304 [details] One more time... Attachment 186304 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16371062
Build Bot
Comment 9 2013-02-03 22:58:13 PST
Comment on attachment 186304 [details] One more time... Attachment 186304 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16357966
Eric Carlson
Comment 10 2013-02-04 07:44:14 PST
Created attachment 186373 [details] Another update.
Build Bot
Comment 11 2013-02-04 10:24:43 PST
Comment on attachment 186373 [details] Another update. Attachment 186373 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16371312
Eric Carlson
Comment 12 2013-02-04 11:12:17 PST
(In reply to comment #11) > (From update of attachment 186373 [details]) > Attachment 186373 [details] did not pass win-ews (win): > Output: http://queues.webkit.org/results/16371312 Not likely to be related: 1>..\cg\ImageDiffCG.cpp(37) : fatal error C1083: Cannot open include file: 'wtf/Platform.h': No such file or directory 1>Build log was saved at "file://C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\obj\ImageDiff\BuildLog.htm"
Eric Carlson
Comment 13 2013-02-04 11:12:48 PST
Created attachment 186420 [details] Updated patch
Dean Jackson
Comment 14 2013-02-04 11:33:58 PST
Comment on attachment 186420 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=186420&action=review > Source/WebCore/page/CaptionUserPreferencesMac.mm:95 > - > + Nit: indent added? > Source/WebCore/page/CaptionUserPreferencesMac.mm:185 > + builder.append(" !important"); Technically I don't think you need the space before the "!", but it doesn't hurt.
Eric Carlson
Comment 15 2013-02-04 11:42:20 PST
Comment on attachment 186420 [details] Updated patch http://trac.webkit.org/r141790
Note You need to log in before you can comment on or make changes to this bug.