Bug 108783 - Update CaptionUserPreferences
Summary: Update CaptionUserPreferences
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-03 18:12 PST by Eric Carlson
Modified: 2013-02-04 11:42 PST (History)
6 users (show)

See Also:


Attachments
Proposed patch (29.76 KB, patch)
2013-02-03 20:44 PST, Eric Carlson
buildbot: commit-queue-
Details | Formatted Diff | Diff
Update patch for my good friend the style bot. (29.61 KB, patch)
2013-02-03 21:13 PST, Eric Carlson
no flags Details | Formatted Diff | Diff
Another update. (30.20 KB, patch)
2013-02-03 21:24 PST, Eric Carlson
buildbot: commit-queue-
Details | Formatted Diff | Diff
One more time... (30.43 KB, patch)
2013-02-03 22:13 PST, Eric Carlson
buildbot: commit-queue-
Details | Formatted Diff | Diff
Another update. (30.42 KB, patch)
2013-02-04 07:44 PST, Eric Carlson
buildbot: commit-queue-
Details | Formatted Diff | Diff
Updated patch (32.99 KB, patch)
2013-02-04 11:12 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-02-03 18:12:40 PST
The system code used to allow the Mac port to modify caption and subtitle style has changed, update for it.
Comment 1 Eric Carlson 2013-02-03 20:44:12 PST
Created attachment 186294 [details]
Proposed patch
Comment 2 WebKit Review Bot 2013-02-03 20:47:23 PST
Attachment 186294 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/CaptionUserPreferences.h', u'Source/WebCore/page/CaptionUserPreferencesMac.h', u'Source/WebCore/page/CaptionUserPreferencesMac.mm', u'Source/WebCore/platform/Language.cpp', u'Source/WebCore/platform/Language.h', u'Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm']" exit_code: 1
Source/WebCore/page/CaptionUserPreferences.h:52:  Too many spaces inside { }.  [whitespace/braces] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2013-02-03 21:11:56 PST
Comment on attachment 186294 [details]
Proposed patch

Attachment 186294 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16365119
Comment 4 Eric Carlson 2013-02-03 21:13:17 PST
Created attachment 186296 [details]
Update patch for my good friend the style bot.
Comment 5 Eric Carlson 2013-02-03 21:24:43 PST
Created attachment 186298 [details]
Another update.
Comment 6 Build Bot 2013-02-03 21:54:03 PST
Comment on attachment 186298 [details]
Another update.

Attachment 186298 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16371034
Comment 7 Eric Carlson 2013-02-03 22:13:38 PST
Created attachment 186304 [details]
One more time...
Comment 8 Build Bot 2013-02-03 22:42:33 PST
Comment on attachment 186304 [details]
One more time...

Attachment 186304 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16371062
Comment 9 Build Bot 2013-02-03 22:58:13 PST
Comment on attachment 186304 [details]
One more time...

Attachment 186304 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16357966
Comment 10 Eric Carlson 2013-02-04 07:44:14 PST
Created attachment 186373 [details]
Another update.
Comment 11 Build Bot 2013-02-04 10:24:43 PST
Comment on attachment 186373 [details]
Another update.

Attachment 186373 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16371312
Comment 12 Eric Carlson 2013-02-04 11:12:17 PST
(In reply to comment #11)
> (From update of attachment 186373 [details])
> Attachment 186373 [details] did not pass win-ews (win):
> Output: http://queues.webkit.org/results/16371312

Not likely to be related: 
1>..\cg\ImageDiffCG.cpp(37) : fatal error C1083: Cannot open include file: 'wtf/Platform.h': No such file or directory
1>Build log was saved at "file://C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\obj\ImageDiff\BuildLog.htm"
Comment 13 Eric Carlson 2013-02-04 11:12:48 PST
Created attachment 186420 [details]
Updated patch
Comment 14 Dean Jackson 2013-02-04 11:33:58 PST
Comment on attachment 186420 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186420&action=review

> Source/WebCore/page/CaptionUserPreferencesMac.mm:95
> -
> +    

Nit: indent added?

> Source/WebCore/page/CaptionUserPreferencesMac.mm:185
> +        builder.append(" !important");

Technically I don't think you need the space before the "!", but it doesn't hurt.
Comment 15 Eric Carlson 2013-02-04 11:42:20 PST
Comment on attachment 186420 [details]
Updated patch

http://trac.webkit.org/r141790