Bug 108766 - Cleanup: Normalize usage of ExceptionCode in ContainerNode::checkXxxChild()
Summary: Cleanup: Normalize usage of ExceptionCode in ContainerNode::checkXxxChild()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks: 108180
  Show dependency treegraph
 
Reported: 2013-02-03 02:16 PST by Mike West
Modified: 2013-02-04 00:28 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.58 KB, patch)
2013-02-03 02:49 PST, Mike West
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2013-02-03 02:16:45 PST
Cleanup: Normalize usage of ExceptionCode in ContainerNode::checkXxxChild()
Comment 1 Mike West 2013-02-03 02:49:53 PST
Created attachment 186256 [details]
Patch
Comment 2 Mike West 2013-02-03 02:53:32 PST
Marking this as blocking the broader https://bugs.webkit.org/show_bug.cgi?id=108180, and adding moritta@, as https://bugs.webkit.org/show_bug.cgi?id=103372 is the last modification to this code.

I've checked the callsites, and this change should have no visible effect other than making the code more consistent, as the calls to checkXXXChild are all prefaced by 'if (ec) return;' statements. Let's see if the bots agree.

WDYT?
Comment 3 Kentaro Hara 2013-02-03 15:48:19 PST
Comment on attachment 186256 [details]
Patch

Looks reasonable. No harm, better consistency.
Comment 4 Mike West 2013-02-04 00:20:56 PST
Comment on attachment 186256 [details]
Patch

Thanks!
Comment 5 WebKit Review Bot 2013-02-04 00:28:28 PST
Comment on attachment 186256 [details]
Patch

Clearing flags on attachment: 186256

Committed r141746: <http://trac.webkit.org/changeset/141746>
Comment 6 WebKit Review Bot 2013-02-04 00:28:31 PST
All reviewed patches have been landed.  Closing bug.