Bug 108761 – [CMake] Don't warn unused cmake variables which aren't used by cmake ports

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gyuyoung Kim]

There is cmake warning because ENABLE_DOM4_EVENTS_CONSTRUCTOR and ENABLE_SUID_SANDBOX_LINUX is not defined in cmake files.

CMake Warning:
  Manually-specified variables were not used by the project:

    ENABLE_DOM4_EVENTS_CONSTRUCTOR
    ENABLE_SUID_SANDBOX_LINUX

[Gyuyoung Kim]

Created attachment 186247 [details]
Patch

[Build Bot]

Comment on attachment 186247 [details]
Patch

Attachment 186247 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16357232

[Laszlo Gombos]

Perhaps we should disable this warning instead of keep adding CMake variables to the build system that does not seems to be used (I do not see a conditional in any CMake file using this guard).

I think if one of the CMake based ports would turn this feature on it would be ok to add this falg (for the purpose of turning it on).

We're planning to  move most of the defining of these flags in .h files and this patch seems to move in the opposite direction.

Here is how to disable the warning - http://www.cmake.org/cmake/help/v2.8.8/cmake.html#opt:--no-warn-unused-cli

[Gyuyoung Kim]

Created attachment 186301 [details]
Patch

[Gyuyoung Kim]

Thank you for your review. I agree to your suggestion. So, I use "--no-warn-unused-cli" option in new patch.

[Build Bot]

Comment on attachment 186301 [details]
Patch

Attachment 186301 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16372077

[Laszlo Gombos]

Comment on attachment 186301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186301&action=review

> Tools/Scripts/webkitdirs.pm:2200
> +    $additionalCMakeArgs = "--no-warn-unused-cli";

It seems to me that (re)setting this variable - instead of appending to it - would loose the CMake arguments passed on the command line to build-webkit. As an example disabling WebKit1 using <<build-webkit --efl --cmakeargs="-DENABLE_WEBKIT=OFF">> probably no longer works with this patch. Can you double-check and perhaps append instead ?

[Gyuyoung Kim]

Created attachment 186527 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #7)
> (From update of attachment 186301 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186301&action=review
> 
> > Tools/Scripts/webkitdirs.pm:2200
> > +    $additionalCMakeArgs = "--no-warn-unused-cli";
> 
> As an example disabling WebKit1 using <<build-webkit --efl --cmakeargs="-DENABLE_WEBKIT=OFF">> probably no longer works with this patch. Can you double-check and perhaps append instead ?

I update this patch. This one works with "-DENABLE_WEBKIT=ON/OFF". Thanks.

[Laszlo Gombos]

Comment on attachment 186527 [details]
Patch

lgtm.

[WebKit Review Bot]

Comment on attachment 186527 [details]
Patch

Clearing flags on attachment: 186527

Committed r141942: <http://trac.webkit.org/changeset/141942>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.