WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
108753
Upstream iOS FeatureDefines
https://bugs.webkit.org/show_bug.cgi?id=108753
Summary
Upstream iOS FeatureDefines
David Kilzer (:ddkilzer)
Reported
2013-02-02 08:36:51 PST
* Configurations/FeatureDefines.xcconfig: - ENABLE_DEVICE_ORIENTATION: Add iOS configurations. - ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto. - FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts. The $(FEATURE_DEFINES_$(PLATFORM_NAME)) variant will prevent additional conflicts in this file while we continue to upstream iOS.
Attachments
Patch v1
(29.75 KB, patch)
2013-02-02 08:40 PST
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2013-02-02 08:40:05 PST
Created
attachment 186232
[details]
Patch v1
Build Bot
Comment 2
2013-02-02 09:50:08 PST
Comment on
attachment 186232
[details]
Patch v1
Attachment 186232
[details]
did not pass win-ews (win): Output:
http://queues.webkit.org/results/16339915
David Kilzer (:ddkilzer)
Comment 3
2013-02-02 10:39:23 PST
Comment on
attachment 186232
[details]
Patch v1 (In reply to
comment #2
)
> (From update of
attachment 186232
[details]
) >
Attachment 186232
[details]
did not pass win-ews (win): > Output:
http://queues.webkit.org/results/16339915
1>..\cg\ImageDiffCG.cpp(37) : fatal error C1083: Cannot open include file: 'wtf/Platform.h': No such file or directory No relationship to this patch.
Build Bot
Comment 4
2013-02-02 10:43:56 PST
Comment on
attachment 186232
[details]
Patch v1
Attachment 186232
[details]
did not pass win-ews (win): Output:
http://queues.webkit.org/results/16335977
David Kilzer (:ddkilzer)
Comment 5
2013-02-02 11:00:20 PST
Comment on
attachment 186232
[details]
Patch v1 (In reply to
comment #4
)
> (From update of
attachment 186232
[details]
) >
Attachment 186232
[details]
did not pass win-ews (win): > Output:
http://queues.webkit.org/results/16335977
Still not related.
WebKit Review Bot
Comment 6
2013-02-02 11:04:11 PST
Comment on
attachment 186232
[details]
Patch v1 Clearing flags on attachment: 186232 Committed
r141699
: <
http://trac.webkit.org/changeset/141699
>
WebKit Review Bot
Comment 7
2013-02-02 11:04:15 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug