Bug 108753 - Upstream iOS FeatureDefines
Summary: Upstream iOS FeatureDefines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-02 08:36 PST by David Kilzer (:ddkilzer)
Modified: 2013-02-02 11:04 PST (History)
5 users (show)

See Also:

Attachments
Patch v1 (29.75 KB, patch)
2013-02-02 08:40 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2013-02-02 08:36:51 PST 
* Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO.  Add
  PLATFORM_NAME variant to reduce future merge conflicts.

The $(FEATURE_DEFINES_$(PLATFORM_NAME)) variant will prevent additional conflicts in this file while we continue to upstream iOS.
Comment 1 David Kilzer (:ddkilzer) 2013-02-02 08:40:05 PST 
Created attachment 186232 [details]
Patch v1
Comment 2 Build Bot 2013-02-02 09:50:08 PST 
Comment on attachment 186232 [details]
Patch v1

Attachment 186232 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16339915
Comment 3 David Kilzer (:ddkilzer) 2013-02-02 10:39:23 PST 
Comment on attachment 186232 [details]
Patch v1

(In reply to comment #2)
> (From update of attachment 186232 [details])
> Attachment 186232 [details] did not pass win-ews (win):
> Output: http://queues.webkit.org/results/16339915

1>..\cg\ImageDiffCG.cpp(37) : fatal error C1083: Cannot open include file: 'wtf/Platform.h': No such file or directory

No relationship to this patch.
Comment 4 Build Bot 2013-02-02 10:43:56 PST 
Comment on attachment 186232 [details]
Patch v1

Attachment 186232 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16335977
Comment 5 David Kilzer (:ddkilzer) 2013-02-02 11:00:20 PST 
Comment on attachment 186232 [details]
Patch v1

(In reply to comment #4)
> (From update of attachment 186232 [details])
> Attachment 186232 [details] did not pass win-ews (win):
> Output: http://queues.webkit.org/results/16335977

Still not related.
Comment 6 WebKit Review Bot 2013-02-02 11:04:11 PST 
Comment on attachment 186232 [details]
Patch v1

Clearing flags on attachment: 186232

Committed r141699: <http://trac.webkit.org/changeset/141699>
Comment 7 WebKit Review Bot 2013-02-02 11:04:15 PST 
All reviewed patches have been landed.  Closing bug.