RESOLVED FIXED 108752
class="cue" is getting some default style
https://bugs.webkit.org/show_bug.cgi?id=108752
Summary class="cue" is getting some default style
Dean Jackson
Reported 2013-02-02 06:13:08 PST
Created attachment 186228 [details] Testcase See testcase. Anything with class="cue" is getting some default style. For example, display: block no matter what you set in CSS. This is a regression since <whatever WebKit is in Safari 6> My guess is that video captions are doing something.
Attachments
Testcase (391 bytes, text/html)
2013-02-02 06:13 PST, Dean Jackson
no flags
Proposed fix 0.1 (4.43 KB, patch)
2013-02-04 12:40 PST, Dima Gorbik
no flags
Radar WebKit Bug Importer
Comment 1 2013-02-02 06:13:21 PST
Dean Jackson
Comment 2 2013-02-02 06:21:06 PST
Actually, might not be some default style. Could just be something that overrides the display property. That's the only property I've been able to find this happen to.
Dean Jackson
Comment 3 2013-02-02 13:43:29 PST
Dean Jackson
Comment 4 2013-02-02 13:47:43 PST
My guess is Source/WebCore/css/RuleSet.cpp - if (component->pseudoType() == CSSSelector::PseudoCue) + if (component->pseudoType() == CSSSelector::PseudoCue || (component->m_match != CSSSelector::Tag && component->value() == TextTrackCue::cueShadowPseudoId()))
Dima Gorbik
Comment 5 2013-02-04 12:40:06 PST
Created attachment 186440 [details] Proposed fix 0.1
WebKit Review Bot
Comment 6 2013-02-04 13:47:16 PST
Comment on attachment 186440 [details] Proposed fix 0.1 Clearing flags on attachment: 186440 Committed r141806: <http://trac.webkit.org/changeset/141806>
WebKit Review Bot
Comment 7 2013-02-04 13:47:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.