RESOLVED INVALID 108750
Add Antoine Quint to the list of committers 
https://bugs.webkit.org/show_bug.cgi?id=108750
Summary Add Antoine Quint to the list of committers
Antoine Quint
Reported 2013-02-02 05:24:55 PST
Add Antoine Quint to the list of committers
Attachments
Patch (1.93 KB, patch)
2013-02-02 05:25 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2013-02-02 05:25:51 PST
Created attachment 186226 [details] Patch
WebKit Review Bot
Comment 2 2013-02-02 06:11:24 PST
Comment on attachment 186226 [details] Patch Clearing flags on attachment: 186226 Committed r141693: <http://trac.webkit.org/changeset/141693>
WebKit Review Bot
Comment 3 2013-02-02 06:11:27 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 4 2013-02-02 09:36:33 PST
Rolled out in r141698. It is not allowed to use commit queue to become a committer, this change must be landed manually (no review needed, no bugzilla bug needed). This proves that Apple actually received committer agreement, and created an account. This admittedly makes less sense for Apple employees, but doing this differently is misleading.
Dean Jackson
Comment 5 2013-02-02 14:51:23 PST
(In reply to comment #4) > Rolled out in r141698. It is not allowed to use commit queue to become a committer, this change must be landed manually (no review needed, no bugzilla bug needed). > > This proves that Apple actually received committer agreement, and created an account. This admittedly makes less sense for Apple employees, but doing this differently is misleading. No problem. I'll land manually.
Dean Jackson
Comment 6 2013-02-02 15:03:52 PST
Landed in http://trac.webkit.org/changeset/141707 (even though we don't need a bugzilla)
Eric Seidel (no email)
Comment 7 2013-02-02 16:40:54 PST
(In reply to comment #6) > Landed in http://trac.webkit.org/changeset/141707 > (even though we don't need a bugzilla) The point is that Antoine is supposed to land it to prove he has rights. :)
Dean Jackson
Comment 8 2013-02-02 23:48:43 PST
(In reply to comment #7) > (In reply to comment #6) > > Landed in http://trac.webkit.org/changeset/141707 > > (even though we don't need a bugzilla) > > The point is that Antoine is supposed to land it to prove he has rights. :) OMG! Now I get it!! I'm not sure what was wrong with my brain that caused me to not understand this :) Honestly, I think this was a senior moment.
Note You need to log in before you can comment on or make changes to this bug.