WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
108749
Check PrivateHeaders/JSBasePrivate.h for inappropriate macros
https://bugs.webkit.org/show_bug.cgi?id=108749
Summary
Check PrivateHeaders/JSBasePrivate.h for inappropriate macros
David Kilzer (:ddkilzer)
Reported
2013-02-02 05:01:22 PST
* JavaScriptCore.xcodeproj/project.pbxproj: Add PrivateHeaders/JSBasePrivate.h to list of headers to check in "Check for Inappropriate Macros in External Headers" build phase script.
Attachments
Patch v1
(1.89 KB, patch)
2013-02-02 05:03 PST
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2013-02-02 05:03:36 PST
Created
attachment 186223
[details]
Patch v1
Build Bot
Comment 2
2013-02-02 06:08:30 PST
Comment on
attachment 186223
[details]
Patch v1
Attachment 186223
[details]
did not pass win-ews (win): Output:
http://queues.webkit.org/results/16340761
David Kilzer (:ddkilzer)
Comment 3
2013-02-02 08:41:50 PST
(In reply to
comment #2
)
> (From update of
attachment 186223
[details]
) >
Attachment 186223
[details]
did not pass win-ews (win): > Output:
http://queues.webkit.org/results/16340761
1>..\cg\ImageDiffCG.cpp(37) : fatal error C1083: Cannot open include file: 'wtf/Platform.h': No such file or directory Hmm...could this patch have caused that?
David Kilzer (:ddkilzer)
Comment 4
2013-02-02 09:12:20 PST
Comment on
attachment 186223
[details]
Patch v1 (In reply to
comment #3
)
> (In reply to
comment #2
) > > (From update of
attachment 186223
[details]
[details]) > >
Attachment 186223
[details]
[details] did not pass win-ews (win): > > Output:
http://queues.webkit.org/results/16340761
> > 1>..\cg\ImageDiffCG.cpp(37) : fatal error C1083: Cannot open include file: 'wtf/Platform.h': No such file or directory > > Hmm...could this patch have caused that?
Nope.
Joseph Pecoraro
Comment 5
2013-02-04 10:45:35 PST
Comment on
attachment 186223
[details]
Patch v1 r=me
WebKit Review Bot
Comment 6
2013-02-04 11:03:20 PST
Comment on
attachment 186223
[details]
Patch v1 Clearing flags on attachment: 186223 Committed
r141786
: <
http://trac.webkit.org/changeset/141786
>
WebKit Review Bot
Comment 7
2013-02-04 11:03:25 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug