Bug 108747 – [GTK] inspector-protocol/page/javascriptDialogEvents.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Zan Dobersek]

Diff:

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/inspector-protocol/page/javascriptDialogEvents-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/inspector-protocol/page/javascriptDialogEvents-actual.txt
@@ -1,4 +1,4 @@
-CONFIRM NAVIGATION: beforeunload
+CONFIRM: beforeunload
 ALERT: alert
 CONFIRM: confirm
 PROMPT: prompt, default text: 

There's probably an unimplemented functionality in DRT that's making this test fail.

[Kwang Yul Seo]

Created attachment 187059 [details]
Patch

[WebKit Review Bot]

Attachment 187059 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/gtk/TestExpectations', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/gtk/webkit/webkitwebview.h', u'Tools/ChangeLog', u'Tools/DumpRenderTree/gtk/DumpRenderTree.cpp']" exit_code: 1
Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1424:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/gtk/webkit/webkitwebview.h:158:  Extra space between WebKitWebFrame and *frame  [whitespace/declaration] [3]
Source/WebKit/gtk/webkit/webkitwebview.h:158:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/gtk/webkit/webkitwebview.h:159:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/gtk/webkit/webkitwebview.h:160:  Extra space between gboolean and *did_confirm  [whitespace/declaration] [3]
Source/WebKit/gtk/webkit/webkitwebview.h:160:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/gtk/webkit/webkitwebview.cpp:2303:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 7 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kwang Yul Seo]

(In reply to comment #2)
> If any of these errors are false positives, please file a bug against check-webkit-style.

Can I disable style checks for WebKitGKT+ specific files?

[Kwang Yul Seo]

mrobinson, as we talked over the IRC, this patch exposes a new signal, "before-unload-confirm" to the WebKitGTK+ public API. 

As you know, the current WebKitGTK+ does not make a distinction between "before-unload-confirm" and "script-confirm", and use "script-confirm" for both cases. This is problematic here because TestRunner handles them differently. To pass inspector-protocol/page/javascriptDialogEvents.html, we need to add "before-unload-confirm".

IMHO, it seems this small API change (adding a signal) is harmless for most existing WebKitGTK+-based browsers and applications because the default signal handler is still the same (showing a modal dialog). 

However, I do understand that WebKit1 GTK is in maintenance mode and we are reluctant to change. This helps solving my problem in fixing our legacy browser, but it not absolutely necessary. So the judge is on your side. Please let me know your final decision :)

[Gustavo Noronha (kov)]

Comment on attachment 187059 [details]
Patch

We don't have a WebKit1 port anymore. Is this an issue for WebKit2GTK+ as well, Zan?

[Diego Pino]

There are no references to this bug in any TestExpectations. It's probable this bug was solved at some point but it wasn't marked as closed. I'm closing this bug now. If you think this bug report is still valid, please reopen it and add an entry to TestExpectations.