RESOLVED FIXED 108742
Avoid String->AtomicString conversion in Attr::childrenChanged() 
https://bugs.webkit.org/show_bug.cgi?id=108742
Summary Avoid String->AtomicString conversion in Attr::childrenChanged()
Benjamin Poulain
Reported 2013-02-01 20:42:34 PST
Avoid String->AtomicString conversion in Attr::childrenChanged()
Attachments
Patch (1.38 KB, patch)
2013-02-01 20:48 PST, Benjamin Poulain 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Same patch (1.38 KB, patch)
2013-02-05 12:52 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-02-01 20:48:11 PST
Created attachment 186210 [details] Patch
Build Bot
Comment 2 2013-02-01 22:17:49 PST
Comment on attachment 186210 [details] Patch Attachment 186210 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16330612 New failing tests: fast/dom/Attr/change-id-via-attr-node-value.html fast/dom/attribute-empty-value-no-children.html dom/html/level1/core/hc_attrremovechild1.html dom/xhtml/level1/core/hc_attrremovechild1.xhtml dom/xhtml/level3/core/documentadoptnode16.xhtml
WebKit Review Bot
Comment 3 2013-02-02 01:53:48 PST
Comment on attachment 186210 [details] Patch Attachment 186210 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16337689 New failing tests: fast/dom/Attr/change-id-via-attr-node-value.html dom/xhtml/level3/core/documentadoptnode16.xhtml fast/dom/attribute-empty-value-no-children.html dom/html/level1/core/hc_attrremovechild1.html dom/xhtml/level1/core/hc_attrremovechild1.xhtml
Benjamin Poulain
Comment 4 2013-02-02 02:54:24 PST
Comment on attachment 186210 [details] Patch The failures are quite interesting. I guess somewhere in there we make the difference between null and empty atomic strings. I'll have to investigate.
Build Bot
Comment 5 2013-02-02 03:34:50 PST
Comment on attachment 186210 [details] Patch Attachment 186210 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16341701 New failing tests: fast/dom/attribute-empty-value-no-children.html fast/dom/Attr/change-id-via-attr-node-value.html dom/xhtml/level3/core/documentadoptnode16.xhtml dom/html/level1/core/hc_attrremovechild1.html dom/xhtml/level1/core/hc_attrremovechild1.xhtml
Darin Adler
Comment 6 2013-02-04 09:21:25 PST
The failure here is due to a bug in StringBuilder::toAtomicString. For zero length, StringBuilder::toAtomicString returns a null string, but it is supposed to return an empty string. StringBuilder::toString returns an empty string for zero length, as it should.
Darin Adler
Comment 7 2013-02-04 09:22:43 PST
First cut at a fix for that would be to return emptyAtom instead of AtomicString() when length is zero.
Benjamin Poulain
Comment 8 2013-02-05 12:52:20 PST
Created attachment 186680 [details] Same patch Same patch, after r141917 fixes AtomicString.
Benjamin Poulain
Comment 9 2013-02-05 14:35:08 PST
Comment on attachment 186680 [details] Same patch Clearing flags on attachment: 186680 Committed r141935: <http://trac.webkit.org/changeset/141935>
Benjamin Poulain
Comment 10 2013-02-05 14:35:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.