WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
108741
Kill suspendAnimation(), resumeAnimation() and numberOfActiveAnimations() from DRT/WTR; use Internals
https://bugs.webkit.org/show_bug.cgi?id=108741
Summary
Kill suspendAnimation(), resumeAnimation() and numberOfActiveAnimations() fro...
Benjamin Poulain
Reported
2013-02-01 19:50:17 PST
Kill suspendAnimation(), resumeAnimation() and numberOfActiveAnimations() from DRT/WTR; use Internals
Attachments
Patch
(46.23 KB, patch)
2013-02-01 19:53 PST
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
Patch
(48.72 KB, patch)
2013-02-04 14:13 PST
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2013-02-01 19:53:42 PST
Created
attachment 186207
[details]
Patch
Build Bot
Comment 2
2013-02-01 20:51:24 PST
Comment on
attachment 186207
[details]
Patch
Attachment 186207
[details]
did not pass win-ews (win): Output:
http://queues.webkit.org/results/16340481
Tony Chang
Comment 3
2013-02-04 09:40:50 PST
Comment on
attachment 186207
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=186207&action=review
Looks like you need to update some exports.
> Source/WebCore/testing/Internals.cpp:417 > +void Internals::suspendAnimations(Document* document, ExceptionCode& ec) const
It would be nice to drop the document parameter, but doing that as a separate change would also be OK.
Benjamin Poulain
Comment 4
2013-02-04 14:13:42 PST
Created
attachment 186458
[details]
Patch
Benjamin Poulain
Comment 5
2013-02-04 20:22:39 PST
Comment on
attachment 186458
[details]
Patch Clearing flags on attachment: 186458 Committed
r141849
: <
http://trac.webkit.org/changeset/141849
>
Benjamin Poulain
Comment 6
2013-02-04 20:22:44 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug