Bug 108734 - Fixed and sticky nodes have no nodeID set
Summary: Fixed and sticky nodes have no nodeID set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-01 18:06 PST by Simon Fraser (smfr)
Modified: 2013-02-02 13:04 PST (History)
6 users (show)

See Also:


Attachments
Patch (14.50 KB, patch)
2013-02-01 21:13 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-02-01 18:06:12 PST
Fixed and sticky nodes in the scrolling tree have m_nodeID set to 0, which seems wrong (but harmless).
Comment 1 Simon Fraser (smfr) 2013-02-01 18:07:59 PST
@@ -182,6 +183,7 @@ void ScrollingTree::updateTreeFromStateNode(ScrollingStateNode* stateNode)
                 newNode->setParent(parent);
                 parent->appendChild(newNode.release());
             }
+            newNodeRawPtr->setScrollingNodeID(stateNode->scrollingNodeID());
             newNodeRawPtr->update(stateNode);
         }
     }
Comment 2 Simon Fraser (smfr) 2013-02-01 21:13:34 PST
Created attachment 186213 [details]
Patch
Comment 3 WebKit Review Bot 2013-02-02 13:04:52 PST
Comment on attachment 186213 [details]
Patch

Clearing flags on attachment: 186213

Committed r141703: <http://trac.webkit.org/changeset/141703>
Comment 4 WebKit Review Bot 2013-02-02 13:04:56 PST
All reviewed patches have been landed.  Closing bug.