WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
108729
Allow TiledCoreAnimationDrawingArea overlay layers to become tiled
https://bugs.webkit.org/show_bug.cgi?id=108729
Summary
Allow TiledCoreAnimationDrawingArea overlay layers to become tiled
Tim Horton
Reported
2013-02-01 17:24:06 PST
In some cases, we need the view-sized layer that TiledCoreAnimationDrawingArea uses for the page overlay to become tiled (if the view is huge). So we should do that, and make sure the relevant TileCache has the view's exposed rect so it can make the right set of tiles. <
rdar://problem/13047546
>
Attachments
patch
(8.84 KB, patch)
2013-02-01 17:42 PST
,
Tim Horton
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2013-02-01 17:42:27 PST
Created
attachment 186197
[details]
patch
Anders Carlsson
Comment 2
2013-02-04 11:17:04 PST
Comment on
attachment 186197
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=186197&action=review
> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:347 > + if (m_pageOverlayLayer) > + if (TiledBacking* tiledBacking = m_pageOverlayLayer->tiledBacking()) > + tiledBacking->setExposedRect(exposedRect);
Outer if statement should have braces.
> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:356 > + if (m_pageOverlayLayer) > + if (TiledBacking* tiledBacking = m_pageOverlayLayer->tiledBacking()) > + tiledBacking->setClipsToExposedRect(!isScrollable);
Outer if statement should have braces.
Tim Horton
Comment 3
2013-02-04 11:28:10 PST
http://trac.webkit.org/changeset/141789
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug