Bug 108719 – [chromium] Flings should not bubble up to enclosing scrollables when main-thread touch scrolling

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Terry Anderson]

Flings should not bubble up to enclosing scrollables when main-thread touch scrolling.

[Terry Anderson]

Created attachment 186177 [details]
WIP

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Robert Kroeger]

FWIW: the fling code in WebViewImpl and related event changes look good to me.

[Terry Anderson]

Created attachment 186445 [details]
Patch

[WebKit Review Bot]

Comment on attachment 186445 [details]
Patch

Attachment 186445 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16374325

[WebKit Review Bot]

Comment on attachment 186445 [details]
Patch

Attachment 186445 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16371423

[Peter Beverloo (cr-android ews)]

Comment on attachment 186445 [details]
Patch

Attachment 186445 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16378284

[Terry Anderson]

Created attachment 186912 [details]
Patch

[Peter Beverloo (cr-android ews)]

Comment on attachment 186912 [details]
Patch

Attachment 186912 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16394390

[Terry Anderson]

Created attachment 186953 [details]
Patch

[Terry Anderson]

Created attachment 187091 [details]
Patch

[Eric Seidel (no email)]

Looks very reasonable. :)  How does one test this?

[Build Bot]

Comment on attachment 187091 [details]
Patch

Attachment 187091 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16428331

[Terry Anderson]

(In reply to comment #12)
> Looks very reasonable. :)  How does one test this?

I have tested the behavior of the new event type GestureScrollUpdateWithoutPropagation in isolation for https://bugs.webkit.org/show_bug.cgi?id=108849, and testing fling itself (such as in fast/events/touch/gesture/pad-gesture-fling.html) is notoriously flaky.

[Terry Anderson]

Created attachment 187173 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 187173 [details]
Patch

I worry w/o automated testing this will break again. :(

[Terry Anderson]

(In reply to comment #16)
> (From update of attachment 187173 [details])
> I worry w/o automated testing this will break again. :(

I definitely agree that some reliable automated testing for fling gestures would be welcome (but in speaking with @rjkroege, this will likely require a substantial effort to make robust). I have filed https://bugs.webkit.org/show_bug.cgi?id=109234 to track.

[WebKit Review Bot]

Comment on attachment 187173 [details]
Patch

Clearing flags on attachment: 187173

Committed r142197: <http://trac.webkit.org/changeset/142197>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.