Remove duplicate code in RenderBoxModelObject::computedCSSPadding*

[Emil A Eklund]

The computedCSSPaddingTop/Bottom/... methods in RenderBoxModelObject all do pretty much exactly the same thing yet share no code.

[Emil A Eklund]

Created attachment 186160 [details]
Patch

[Levi Weintraub]

Comment on attachment 186160 [details]
Patch

Hallelujah!

[WebKit Review Bot]

Comment on attachment 186160 [details]
Patch

Clearing flags on attachment: 186160

Committed r141669: <http://trac.webkit.org/changeset/141669>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Jessie Berlin]

(In reply to comment #3)
> (From update of attachment 186160 [details])
> Clearing flags on attachment: 186160
> 
> Committed r141669: <http://trac.webkit.org/changeset/141669>

This broke the Windows build:

http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/61773/steps/compile-webkit/logs/stdio

7>LINK : warning LNK4075: ignoring '/INCREMENTAL' due to '/LTCG' specification
7>WebCore.lib(RenderSVGAllInOne.obj) : error LNK2005: "public: class WebCore::LayoutUnit __thiscall WebCore::RenderBoxModelObject::computedCSSPaddingTop(void)const " (?computedCSSPaddingTop@RenderBoxModelObject@WebCore@@QBE?AVLayoutUnit@2@XZ) already defined in WebCore.lib(RenderingAllInOne.obj)
7>WebCore.lib(RenderSVGAllInOne.obj) : error LNK2005: "public: class WebCore::LayoutUnit __thiscall WebCore::RenderBoxModelObject::computedCSSPaddingBottom(void)const " (?computedCSSPaddingBottom@RenderBoxModelObject@WebCore@@QBE?AVLayoutUnit@2@XZ) already defined in WebCore.lib(RenderingAllInOne.obj)
7>WebCore.lib(RenderSVGAllInOne.obj) : error LNK2005: "public: class WebCore::LayoutUnit __thiscall WebCore::RenderBoxModelObject::computedCSSPaddingLeft(void)const " (?computedCSSPaddingLeft@RenderBoxModelObject@WebCore@@QBE?AVLayoutUnit@2@XZ) already defined in WebCore.lib(RenderingAllInOne.obj)
7>WebCore.lib(RenderSVGAllInOne.obj) : error LNK2005: "public: class WebCore::LayoutUnit __thiscall WebCore::RenderBoxModelObject::computedCSSPaddingRight(void)const " (?computedCSSPaddingRight@RenderBoxModelObject@WebCore@@QBE?AVLayoutUnit@2@XZ) already defined in WebCore.lib(RenderingAllInOne.obj)
7>WebCore.lib(RenderSVGAllInOne.obj) : error LNK2005: "public: class WebCore::LayoutUnit __thiscall WebCore::RenderBoxModelObject::computedCSSPaddingBefore(void)const " (?computedCSSPaddingBefore@RenderBoxModelObject@WebCore@@QBE?AVLayoutUnit@2@XZ) already defined in WebCore.lib(RenderingAllInOne.obj)
7>WebCore.lib(RenderSVGAllInOne.obj) : error LNK2005: "public: class WebCore::LayoutUnit __thiscall WebCore::RenderBoxModelObject::computedCSSPaddingAfter(void)const " (?computedCSSPaddingAfter@RenderBoxModelObject@WebCore@@QBE?AVLayoutUnit@2@XZ) already defined in WebCore.lib(RenderingAllInOne.obj)
7>WebCore.lib(RenderSVGAllInOne.obj) : error LNK2005: "public: class WebCore::LayoutUnit __thiscall WebCore::RenderBoxModelObject::computedCSSPaddingStart(void)const " (?computedCSSPaddingStart@RenderBoxModelObject@WebCore@@QBE?AVLayoutUnit@2@XZ) already defined in WebCore.lib(RenderingAllInOne.obj)

[WebKit Review Bot]

Re-opened since this is blocked by bug 108728

[Emil A Eklund]

Thanks for rolling it out.

Probably just needs to force a rebuild (or revalidation of the all in one file). Will try to figure out a way to commit in a way that doesn't break windows.

[Eric Seidel (no email)]

Comment on attachment 186160 [details]
Patch

Wow.

[Eric Seidel (no email)]

Oh, sorry, I guess you didn't need another r+.

[Emil A Eklund]

Committed r141775: <http://trac.webkit.org/changeset/141775>