Bug 108705 - Update LayoutTests scripts to skip webgl folder on ports
Summary: Update LayoutTests scripts to skip webgl folder on ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Gregg Tavares
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-01 15:11 PST by Gregg Tavares
Modified: 2013-02-01 18:18 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.51 KB, patch)
2013-02-01 15:12 PST, Gregg Tavares
no flags Details | Formatted Diff | Diff
Patch (3.54 KB, patch)
2013-02-01 15:24 PST, Gregg Tavares
no flags Details | Formatted Diff | Diff
Patch (3.54 KB, patch)
2013-02-01 15:31 PST, Gregg Tavares
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gregg Tavares 2013-02-01 15:11:25 PST
Update LayoutTests scripts to skip webgl folder on ports
Comment 1 Gregg Tavares 2013-02-01 15:12:51 PST
Created attachment 186156 [details]
Patch
Comment 2 Gregg Tavares 2013-02-01 15:14:41 PST
Before I check in the WebGL Conformance Tests I think I need this change so that ports that do not support WebGL skip the tests
Comment 3 WebKit Review Bot 2013-02-01 15:16:03 PST
Attachment 186156 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/layout_tests/port/base.py', u'Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py']" exit_code: 1
Tools/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Tools/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Tools/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Tools/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dirk Pranke 2013-02-01 15:20:22 PST
Comment on attachment 186156 [details]
Patch

looks fine. fix the style errors :)
Comment 5 Gregg Tavares 2013-02-01 15:24:39 PST
Created attachment 186161 [details]
Patch
Comment 6 Gregg Tavares 2013-02-01 15:31:39 PST
Created attachment 186164 [details]
Patch
Comment 7 WebKit Review Bot 2013-02-01 18:18:27 PST
Comment on attachment 186164 [details]
Patch

Clearing flags on attachment: 186164

Committed r141672: <http://trac.webkit.org/changeset/141672>
Comment 8 WebKit Review Bot 2013-02-01 18:18:31 PST
All reviewed patches have been landed.  Closing bug.