Bug 108694 – [WEBGL] Rename WEBKIT_WEBGL_lose_context to WEBGL_lose_context.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Nayan Kumar K]

Now that WEBGL_lose_context is one the community approved extension (http://www.khronos.org/registry/webgl/extensions/), remove the 'WEBKIT' vendor prefix from WEBKIT_WEBGL_lose_context.

[Nayan Kumar K]

Created attachment 186141 [details]
Patch

[Build Bot]

Comment on attachment 186141 [details]
Patch

Attachment 186141 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16330256

New failing tests:
fast/canvas/webgl/context-lost-restored.html

[Build Bot]

Comment on attachment 186141 [details]
Patch

Attachment 186141 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16334243

New failing tests:
fast/canvas/webgl/context-lost-restored.html

[WebKit Review Bot]

Comment on attachment 186141 [details]
Patch

Attachment 186141 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16339444

New failing tests:
fast/canvas/webgl/context-lost.html
platform/chromium/virtual/gpu/fast/canvas/webgl/context-lost-restored.html
platform/chromium/virtual/gpu/fast/canvas/webgl/context-lost.html
fast/canvas/webgl/context-lost-restored.html

[Kenneth Russell]

Comment on attachment 186141 [details]
Patch

In principle this change looks good, but why are the tests failing?

Would you please submit a pull request to https://github.com/KhronosGroup/WebGL to update the conformance tests there? In those tests, I think they should continue to support the legacy (prefixed) extension name for a while, until all browsers have shipped the unprefixed name.

[Nayan Kumar K]

Created attachment 186442 [details]
Fix for layout failing layout tests

[Nayan Kumar K]

(In reply to comment #5)
> (From update of attachment 186141 [details])
> In principle this change looks good, but why are the tests failing?

Seems like context-lost.html needed per-platform baseline files. Also fixed a bug in context-lost-restored.html. Uploaded the new patch for review, hopefully it passes all layout tests.

> 
> Would you please submit a pull request to https://github.com/KhronosGroup/WebGL to update the conformance tests there? In those tests, I think they should continue to support the legacy (prefixed) extension name for a while, until all browsers have shipped the unprefixed name.

Sure. I will submit a pull request soon.

[Kenneth Russell]

Comment on attachment 186442 [details]
Fix for layout failing layout tests

Thanks. Looks good.

[Kenneth Russell]

Did you want this patch submitted to the commit queue? Mark cq? if so.

[WebKit Review Bot]

Comment on attachment 186442 [details]
Fix for layout failing layout tests

Clearing flags on attachment: 186442

Committed r141845: <http://trac.webkit.org/changeset/141845>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.