Bug 108693 - Make ConfigurationBuildDir include directories precede WebKitLibraries in JSC
Summary: Make ConfigurationBuildDir include directories precede WebKitLibraries in JSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-01 14:20 PST by Roger Fong
Modified: 2013-02-05 13:19 PST (History)
3 users (show)

See Also:

Attachments
patch (2.46 KB, patch)
2013-02-01 14:23 PST, Roger Fong 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2013-02-01 14:20:50 PST 
ConfigurationBuildDir includes should precede WebKitLibraries.

This is because some files in the newer WebKitLibaries versions have overlapping files "include/private/wtf".
These files will not necessarily match up with whatever is on ToT since new WebKitLibraries are only released periodically.

This caused build issues when using a newer WebKitLibraries version, specifically in JSC.
JSC should prioritize the files in the build directory which are copied from ToT when searching for file includes.

This might also be an issue in other projects down the road but I think taking a "fix it as they come" approach is better here.
Comment 1 Roger Fong 2013-02-01 14:23:37 PST 
Created attachment 186138 [details]
patch
Comment 2 Roger Fong 2013-02-05 13:13:58 PST 
Comment on attachment 186138 [details]
patch

rubberstamped by thorton
Comment 3 Roger Fong 2013-02-05 13:18:56 PST 
http://trac.webkit.org/changeset/141921