Add round braces to javascript tokenizer.
This change will be used in brace highlighter functionality.
Created attachment 186137 [details] Patch
Comment on attachment 186137 [details] Patch testcases not updated.
Created attachment 186149 [details] Patch
Comment on attachment 186149 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186149&action=review > Source/WebCore/inspector/front-end/SourceJavaScriptTokenizer.re2js:-180 > - <DIV,NODIV> RightParen => DIV { this.tokenType = null; return cursor; } DIV,NODIV => DIV means that we transition from the state where division is expected or not expected into the state where it is expected (this is due to "/" ambiguity - it might be division or regex start).
Created attachment 186235 [details] Patch
Comment on attachment 186149 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186149&action=review >> Source/WebCore/inspector/front-end/SourceJavaScriptTokenizer.re2js:-180 >> - <DIV,NODIV> RightParen => DIV { this.tokenType = null; return cursor; } > > DIV,NODIV => DIV means that we transition from the state where division is expected or not expected into the state where it is expected (this is due to "/" ambiguity - it might be division or regex start). thanks for clarifying this moment!
Comment on attachment 186235 [details] Patch Attachment 186235 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16343994
Comment on attachment 186235 [details] Patch Attachment 186235 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16359020
Comment on attachment 186235 [details] Patch Clearing flags on attachment: 186235 Committed r141774: <http://trac.webkit.org/changeset/141774>
All reviewed patches have been landed. Closing bug.