Bug 108685 - Web Inspector: fix bug in highlighting single chars via highlightRange API of DTE
Summary: Web Inspector: fix bug in highlighting single chars via highlightRange API of...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on: 108679
Blocks: 108697
  Show dependency treegraph
 
Reported: 2013-02-01 13:44 PST by Andrey Lushnikov
Modified: 2013-02-02 04:00 PST (History)
11 users (show)

See Also:


Attachments
Patch (4.73 KB, patch)
2013-02-01 13:51 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff
Patch (4.57 KB, patch)
2013-02-01 21:42 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-02-01 13:44:50 PST
if you try to highlight a single char via highlightRange method of DTE, it will actually highlight all the way to the end of the line.
Comment 1 Andrey Lushnikov 2013-02-01 13:47:12 PST
to reviewer: this bug depends on https://bugs.webkit.org/show_bug.cgi?id=108679, so please do not cq+ it unless that one is landed.
Comment 2 Andrey Lushnikov 2013-02-01 13:51:10 PST
Created attachment 186129 [details]
Patch
Comment 3 Build Bot 2013-02-01 15:57:24 PST
Comment on attachment 186129 [details]
Patch

Attachment 186129 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16336261

New failing tests:
inspector/editor/text-editor-highlight-api.html
Comment 4 Build Bot 2013-02-01 16:39:57 PST
Comment on attachment 186129 [details]
Patch

Attachment 186129 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16343194
Comment 5 Build Bot 2013-02-01 17:38:08 PST
Comment on attachment 186129 [details]
Patch

Attachment 186129 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16330371
Comment 6 Andrey Lushnikov 2013-02-01 21:42:03 PST
Created attachment 186214 [details]
Patch
Comment 7 Build Bot 2013-02-01 23:51:20 PST
Comment on attachment 186214 [details]
Patch

Attachment 186214 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16337621
Comment 8 Build Bot 2013-02-02 01:38:51 PST
Comment on attachment 186214 [details]
Patch

Attachment 186214 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16340592
Comment 9 WebKit Review Bot 2013-02-02 04:00:00 PST
Comment on attachment 186214 [details]
Patch

Clearing flags on attachment: 186214

Committed r141689: <http://trac.webkit.org/changeset/141689>
Comment 10 WebKit Review Bot 2013-02-02 04:00:04 PST
All reviewed patches have been landed.  Closing bug.