Bug 108684 - git.svn_revision doesn't fetch the same revision as svn.svn_revision
Summary: git.svn_revision doesn't fetch the same revision as svn.svn_revision
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Critical
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-01 13:38 PST by Ryosuke Niwa
Modified: 2013-02-07 14:05 PST (History)
6 users (show)

See Also:

Attachments
Fixes the bug (1.33 KB, patch)
2013-02-07 01:34 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-02-01 13:38:10 PST 
We compute the revision against LayoutTests for layout and performance tests but git.svn_revision fetches the latest svn revision in LayoutTests, unlike svn.svn_revision that retrieves the latest svn revision in the entire repository.
Comment 1 Ryosuke Niwa 2013-02-01 13:38:46 PST 
Unfortunately, I don't know git svn well enough to fix this bug.
Comment 2 Ryosuke Niwa 2013-02-01 13:42:11 PST 
Maybe we need to ignore the path in git.svn_revision since you can't really have a partial git checkout like we can with svn.
Comment 3 Ryosuke Niwa 2013-02-01 14:32:56 PST 
andersca suggests we can walk up the directories and look for .git but I wonder if there's a more efficient way of finding the root of a git module?
Comment 4 Eric Seidel (no email) 2013-02-01 21:22:31 PST 
I'm sure mithro can help us here once SYD is awake on monday (which is sunday for us).
Comment 5 Ryosuke Niwa 2013-02-07 01:34:00 PST 
Created attachment 187023 [details]
Fixes the bug
Comment 6 Build Bot 2013-02-07 06:04:29 PST 
Comment on attachment 187023 [details]
Fixes the bug

Attachment 187023 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16435129
Comment 7 Ryosuke Niwa 2013-02-07 13:38:53 PST 
(In reply to comment #6)
> (From update of attachment 187023 [details])
> Attachment 187023 [details] did not pass win-ews (win):
> Output: http://queues.webkit.org/results/16435129

I've notified rfong about the mysterious wtf/Platform.h not found error.
Comment 8 WebKit Review Bot 2013-02-07 14:05:39 PST 
Comment on attachment 187023 [details]
Fixes the bug

Clearing flags on attachment: 187023

Committed r142178: <http://trac.webkit.org/changeset/142178>
Comment 9 WebKit Review Bot 2013-02-07 14:05:44 PST 
All reviewed patches have been landed.  Closing bug.