Bug 108654 - Remove unnecessary parameter from DocumentLoader::scheduleArchiveLoad
Summary: Remove unnecessary parameter from DocumentLoader::scheduleArchiveLoad
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-01 10:22 PST by Brady Eidson
Modified: 2013-02-01 10:32 PST (History)
0 users

See Also:


Attachments
Patch v1 (3.21 KB, patch)
2013-02-01 10:25 PST, Brady Eidson
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-02-01 10:22:44 PST
Remove unnecessary parameter from DocumentLoader::scheduleArchiveLoad

This method takes both a ResourceRequest and a KURL and contains logic assuming the request URL might be different from the separate URL.

In practice, they are always the same.

It's also unclear why we might want them to be different.
Comment 1 Brady Eidson 2013-02-01 10:25:31 PST
Created attachment 186076 [details]
Patch v1
Comment 2 Alexey Proskuryakov 2013-02-01 10:27:27 PST
Comment on attachment 186076 [details]
Patch v1

r=me assuming you grepped over other platforms code (this deals with MHTML and other types we don't enable on Mac).

Removing code is the best kind of patch!
Comment 3 Brady Eidson 2013-02-01 10:28:00 PST
(In reply to comment #2)
> (From update of attachment 186076 [details])
> r=me assuming you grepped over other platforms code (this deals with MHTML and other types we don't enable on Mac).
> 
> Removing code is the best kind of patch!

Grepped over the entire Source/ directory!
Comment 4 Brady Eidson 2013-02-01 10:32:50 PST
http://trac.webkit.org/changeset/141603