RESOLVED FIXED 108654
Remove unnecessary parameter from DocumentLoader::scheduleArchiveLoad 
https://bugs.webkit.org/show_bug.cgi?id=108654
Summary Remove unnecessary parameter from DocumentLoader::scheduleArchiveLoad
Brady Eidson
Reported 2013-02-01 10:22:44 PST
Remove unnecessary parameter from DocumentLoader::scheduleArchiveLoad This method takes both a ResourceRequest and a KURL and contains logic assuming the request URL might be different from the separate URL. In practice, they are always the same. It's also unclear why we might want them to be different.
Attachments
Patch v1 (3.21 KB, patch)
2013-02-01 10:25 PST, Brady Eidson 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2013-02-01 10:25:31 PST
Created attachment 186076 [details] Patch v1
Alexey Proskuryakov
Comment 2 2013-02-01 10:27:27 PST
Comment on attachment 186076 [details] Patch v1 r=me assuming you grepped over other platforms code (this deals with MHTML and other types we don't enable on Mac). Removing code is the best kind of patch!
Brady Eidson
Comment 3 2013-02-01 10:28:00 PST
(In reply to comment #2) > (From update of attachment 186076 [details]) > r=me assuming you grepped over other platforms code (this deals with MHTML and other types we don't enable on Mac). > > Removing code is the best kind of patch! Grepped over the entire Source/ directory!
Brady Eidson
Comment 4 2013-02-01 10:32:50 PST
http://trac.webkit.org/changeset/141603
Note You need to log in before you can comment on or make changes to this bug.