[Chromium] Move IDBFactoryBackendInterface to WebCore
Created attachment 186048 [details] Patch
Comment on attachment 186048 [details] Patch Same technique as bug 108488.
Comment on attachment 186048 [details] Patch Ok.
Comment on attachment 186048 [details] Patch I'm not super excited about this patch. The difference between this patch and the media player patch is that IndexedDB should be scoped to some sort of storage context. For example, the PageGroup, rather than being a static. That said, I think we should go forward with this patch for two reasons: 1) We're already using a static, so we're not really losing anything. 2) We don't currently have the notion of a "storage context", so there isn't really anything to hang this off of today. I suspect we'll eventually revisit this issue, but at least the problem is more visible now that there is code in the initialize function that mentions the static.
Created attachment 186159 [details] Patch
Comment on attachment 186159 [details] Patch Resubmitting same patch due to SVN weirdness. Let's make sure EWS goes green before committing.
(In reply to comment #4) > (From update of attachment 186048 [details]) > I'm not super excited about this patch. The difference between this patch and the media player patch is that IndexedDB should be scoped to some sort of storage context. For example, the PageGroup, rather than being a static. Can't use PageGroup because workers. (We tried.) > I suspect we'll eventually revisit this issue, but at least the problem is more visible now that there is code in the initialize function that mentions the static. Agreed.
Comment on attachment 186159 [details] Patch Attachment 186159 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16341195
Comment on attachment 186159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186159&action=review > Source/WebCore/Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp:44 > + ASSERT(s_idbFactoryCreateFunction); Looks like you've got the wrong name in this ASSERT.
Created attachment 186372 [details] Patch
Comment on attachment 186372 [details] Patch FIxed ASSERT.
Comment on attachment 186372 [details] Patch Clearing flags on attachment: 186372 Committed r141784: <http://trac.webkit.org/changeset/141784>
All reviewed patches have been landed. Closing bug.