Bug 108637 – [chromium] Fat scrollbars on Windows in high-DPI mode.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Kevin Ellis]

[chromium] Fat scrollbars on Windows in high-DPI mode.

[Kevin Ellis]

Created attachment 186047 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Kevin Ellis]

The Windows port of Chromium used GetSystemMetrics to determine the width of a scrollbar.  This works fine if the device scale factor is 1, but results in double scaling of the scrollbar width in high-DPI mode since the system metrics call returns the width in pixels and not logical units.

[Adam Barth]

Comment on attachment 186047 [details]
Patch

Ok.  Is there a test for this issue on the Chromium side?  I know we mock the Windows theme out in the WebKit-side tests.

[Kevin Ellis]

(In reply to comment #4)
> (From update of attachment 186047 [details])
> Ok.  Is there a test for this issue on the Chromium side?  I know we mock the Windows theme out in the WebKit-side tests.

There does not appear to be an automated test on the Chromium side for scrollbar thickness.

[Adam Barth]

Would you be willing to add one (either in WebKit or Chromium---whichever is easier for you)?

[Kevin Ellis]

(In reply to comment #6)
> Would you be willing to add one (either in WebKit or Chromium---whichever is easier for you)?

Yes, I can look into adding a test. My preference is currently leaning to a Chromium-side layout test.

[WebKit Review Bot]

Comment on attachment 186047 [details]
Patch

Rejecting attachment 186047 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 186047, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13563 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
53>At revision 13563.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/16338103

[Kevin Ellis]

Created attachment 186139 [details]
Patch

[WebKit Review Bot]

Comment on attachment 186139 [details]
Patch

Clearing flags on attachment: 186139

Committed r141652: <http://trac.webkit.org/changeset/141652>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.