Bug 108634 - [EFL][WK2] EWK2UnitTestBase.ewk_view_page_contents_get API test is sometimes failing
Summary: [EFL][WK2] EWK2UnitTestBase.ewk_view_page_contents_get API test is sometimes ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 106440
Blocks: 106752
  Show dependency tree / graph
 
Reported: 2013-02-01 06:59 PST by Chris Dumez
Modified: 2013-02-07 10:51 PST (History)
12 users (show)

See Also:

Attachments
Patch (3.05 KB, patch)
2013-02-01 07:10 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-02-01 06:59:37 PST 
EWK2UnitTestBase.ewk_view_page_contents_get APi test sometimes fail due to a fragile check in the test. This should be fixed.

[ RUN      ] EWK2UnitTestBase.ewk_view_page_contents_get
/home/buildslave-1/webkit-buildslave/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:933: Failure
Value of: strncmp(data + 359, lines, strlen(lines))
  Actual: 1
Expected: 0
Comment 1 Chris Dumez 2013-02-01 07:10:18 PST 
Created attachment 186037 [details]
Patch
Comment 2 Sudarsana Nagineni (babu) 2013-02-01 07:24:21 PST 
Comment on attachment 186037 [details]
Patch

LGTM
Comment 3 Gyuyoung Kim 2013-02-01 16:00:33 PST 
Comment on attachment 186037 [details]
Patch

Looks fine.
Comment 4 Chris Dumez 2013-02-03 01:24:22 PST 
Could someone please review this one? Our bots are currently red due to this API test failing.
Comment 5 WebKit Review Bot 2013-02-07 10:51:21 PST 
Comment on attachment 186037 [details]
Patch

Clearing flags on attachment: 186037

Committed r142153: <http://trac.webkit.org/changeset/142153>
Comment 6 WebKit Review Bot 2013-02-07 10:51:26 PST 
All reviewed patches have been landed.  Closing bug.