Bug 108621 - PatchLog process durations are increasing linearly with time (faulty data logging)
Summary: PatchLog process durations are increasing linearly with time (faulty data log...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alan Cutter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-01 05:33 PST by Alan Cutter
Modified: 2013-02-01 07:28 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.55 KB, patch)
2013-02-01 05:42 PST, Alan Cutter 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Cutter 2013-02-01 05:33:00 PST 
http://i.imgur.com/VLpp5D6.png

The Patch stopped event appears to be firing multiple times per patch for some queues. Eg. 185862 on cr-android-ews. http://queues.webkit.org/patch/185862 http://i.imgur.com/vNjr236.png
It's not clear at this stage what is causing the stopped event to fire for this patch on this queue so much.

Not all queues are experiencing this abnormality.

The QSS loggers should be made immune to this behaviour regardless.
Comment 1 Alan Cutter 2013-02-01 05:42:09 PST 
Created attachment 186024 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-02-01 06:15:33 PST 
Comment on attachment 186024 [details]
Patch

LGTM.  Do we need to clear old ones?
Comment 3 Alan Cutter 2013-02-01 06:57:48 PST 
(In reply to comment #2)
> (From update of attachment 186024 [details])
> LGTM.  Do we need to clear old ones?

Thanks Eric.
Once the data logging code has settled down and the kinks are worked out I considering wiping the existing log data since it's full of glitches like these.
Comment 4 WebKit Review Bot 2013-02-01 07:28:50 PST 
Comment on attachment 186024 [details]
Patch

Clearing flags on attachment: 186024

Committed r141590: <http://trac.webkit.org/changeset/141590>
Comment 5 WebKit Review Bot 2013-02-01 07:28:53 PST 
All reviewed patches have been landed.  Closing bug.