RESOLVED FIXED 108611
Web Inspector: Refactor InspectorDOMStorageAgent::getDOMStorageEntries to report the error messages
https://bugs.webkit.org/show_bug.cgi?id=108611
Summary Web Inspector: Refactor InspectorDOMStorageAgent::getDOMStorageEntries to rep...
Vivek Galatage
Reported 2013-02-01 03:53:08 PST
Refactor InspectorDOMStorageAgent::getDOMStorageEntries to report the error messages. Patch follows.
Attachments
Patch (3.30 KB, patch)
2013-02-01 03:59 PST, Vivek Galatage
no flags
Patch (4.07 KB, patch)
2013-02-01 16:21 PST, Vivek Galatage
no flags
Vivek Galatage
Comment 1 2013-02-01 03:59:43 PST
Alexander Pavlov (apavlov)
Comment 2 2013-02-01 04:15:52 PST
Comment on attachment 186004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186004&action=review > Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:116 > + *errorString = "Storage resource not found for the provided storage Id"; id -> identifier > Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:132 > + if (ec) { Does this (and below) check structure mean you bail out of the method without providing any errorString for the other ec values? You have retained the pre-existing behavior for the other cases, but the code was unable to provide ANY errorString previously :) > Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:133 > + switch (ec) { Not quite sure, but I remember some compilers complain about not all the enum cases being handled if not all of them are enumerated and the switch does not contain the "default:" case.
Yury Semikhatsky
Comment 3 2013-02-01 04:16:54 PST
Comment on attachment 186004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186004&action=review > Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:126 > + entries = TypeBuilder::Array<TypeBuilder::Array<String> >::create(); You shouldn't write to the output parameters partial results in cases there is an error below. You can use local variable to collect the entries and on success assign it to |entries| after the loop below. > Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:136 > + break; Is it the only type of error? If not you should either process all cases or add default: section here providing some generic error message. > Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:145 > + *errorString = "Security error"; ditto, also consider extracting the error handling into a separate function: if (hadException(ec, errorString)) return;
Vivek Galatage
Comment 4 2013-02-01 16:21:23 PST
Vivek Galatage
Comment 5 2013-02-02 04:52:41 PST
Comment on attachment 186182 [details] Patch Thank you!
WebKit Review Bot
Comment 6 2013-02-02 04:56:08 PST
Comment on attachment 186182 [details] Patch Clearing flags on attachment: 186182 Committed r141690: <http://trac.webkit.org/changeset/141690>
WebKit Review Bot
Comment 7 2013-02-02 04:56:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.