Bug 108602 - Web Inspector: [Canvas] UI is not restored properly when deleting a live recording profile
Summary: Web Inspector: [Canvas] UI is not restored properly when deleting a live reco...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-01 02:05 PST by Andrey Adaikin
Modified: 2013-02-05 04:06 PST (History)
9 users (show)

See Also:


Attachments
Patch (4.51 KB, patch)
2013-02-01 02:11 PST, Andrey Adaikin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2013-02-01 02:05:08 PST
Repro:
- start recording canvas consecutive frames
- while recording, delete the profile header
- observe the start button's color is still red

Patch to follow.
Comment 1 Andrey Adaikin 2013-02-01 02:11:42 PST
Created attachment 185985 [details]
Patch
Comment 2 Pavel Feldman 2013-02-04 00:25:47 PST
Comment on attachment 185985 [details]
Patch

Missing a test.
Comment 3 Andrey Adaikin 2013-02-04 03:31:47 PST
(In reply to comment #2)
> (From update of attachment 185985 [details])
> Missing a test.

UI change, manual testing. I dont think we test these.
Comment 4 Pavel Feldman 2013-02-04 03:41:26 PST
Comment on attachment 185985 [details]
Patch

At this point, I don't think proceeding with no tests at all is acceptable. We need at least some acceptance tests.
Comment 5 WebKit Review Bot 2013-02-05 04:06:13 PST
Comment on attachment 185985 [details]
Patch

Clearing flags on attachment: 185985

Committed r141883: <http://trac.webkit.org/changeset/141883>
Comment 6 WebKit Review Bot 2013-02-05 04:06:18 PST
All reviewed patches have been landed.  Closing bug.