WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
108602
Web Inspector: [Canvas] UI is not restored properly when deleting a live recording profile
https://bugs.webkit.org/show_bug.cgi?id=108602
Summary
Web Inspector: [Canvas] UI is not restored properly when deleting a live reco...
Andrey Adaikin
Reported
2013-02-01 02:05:08 PST
Repro: - start recording canvas consecutive frames - while recording, delete the profile header - observe the start button's color is still red Patch to follow.
Attachments
Patch
(4.51 KB, patch)
2013-02-01 02:11 PST
,
Andrey Adaikin
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andrey Adaikin
Comment 1
2013-02-01 02:11:42 PST
Created
attachment 185985
[details]
Patch
Pavel Feldman
Comment 2
2013-02-04 00:25:47 PST
Comment on
attachment 185985
[details]
Patch Missing a test.
Andrey Adaikin
Comment 3
2013-02-04 03:31:47 PST
(In reply to
comment #2
)
> (From update of
attachment 185985
[details]
) > Missing a test.
UI change, manual testing. I dont think we test these.
Pavel Feldman
Comment 4
2013-02-04 03:41:26 PST
Comment on
attachment 185985
[details]
Patch At this point, I don't think proceeding with no tests at all is acceptable. We need at least some acceptance tests.
WebKit Review Bot
Comment 5
2013-02-05 04:06:13 PST
Comment on
attachment 185985
[details]
Patch Clearing flags on attachment: 185985 Committed
r141883
: <
http://trac.webkit.org/changeset/141883
>
WebKit Review Bot
Comment 6
2013-02-05 04:06:18 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug