WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
108596
AX: when aria-activedescendant is used with a ComboBox role, focus should not be changed
https://bugs.webkit.org/show_bug.cgi?id=108596
Summary
AX: when aria-activedescendant is used with a ComboBox role, focus should not...
chris fleizach
Reported
2013-02-01 01:04:44 PST
Normally, an aria-activedescendant change causes a focus change to be triggered. However, when used in conjunction with a combo box, this causes problems for Screen readers. The problem is that the user expects focus to remain in the text field so that the user can keep typing. If it moves to an item in the combobox list, it is not possible to keep typing
Attachments
patch
(8.24 KB, patch)
2013-02-01 01:10 PST
,
chris fleizach
rniwa
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
chris fleizach
Comment 1
2013-02-01 01:04:55 PST
rdar://13093327
chris fleizach
Comment 2
2013-02-01 01:07:05 PST
The solution I think is to not allow focus changes on aria-activedescendant changes for combo boxes. on the mac, we think we should send a selected children changed notification instead
chris fleizach
Comment 3
2013-02-01 01:10:26 PST
Created
attachment 185973
[details]
patch
Ryosuke Niwa
Comment 4
2013-02-01 01:17:20 PST
Comment on
attachment 185973
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=185973&action=review
> LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications.html:21 > + window.jsTestIsAsync = true; > + window.testRunner.waitUntilDone();
You don't need "window.".
> LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt:2 > +item1
Could you hide this before the test finishes so that the expected result will have less noise?
> LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt:9 > +PASS combo.isEqual(accessibilityController.focusedElement) is true > +PASS combo.isEqual(accessibilityController.focusedElement) is true
It's not obvious to me what has been tested. It would have been better if comments in the tests were inside debug or they were wrapped in some inline functions, which are then called in evalAndLog.
chris fleizach
Comment 5
2013-02-01 01:28:30 PST
(In reply to
comment #4
)
> (From update of
attachment 185973
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=185973&action=review
> > > LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications.html:21 > > + window.jsTestIsAsync = true; > > + window.testRunner.waitUntilDone(); > > You don't need "window.". > > > LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt:2 > > +item1 > > Could you hide this before the test finishes so that the expected result will have less noise? > > > LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt:9 > > +PASS combo.isEqual(accessibilityController.focusedElement) is true > > +PASS combo.isEqual(accessibilityController.focusedElement) is true > > It's not obvious to me what has been tested. It would have been better if comments in the tests were inside debug or they were wrapped in some inline functions, which are then called in evalAndLog.
Thanks for the feedback. Will update these
chris fleizach
Comment 6
2013-02-01 01:38:49 PST
http://trac.webkit.org/changeset/141560
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug