Normally, an aria-activedescendant change causes a focus change to be triggered. However, when used in conjunction with a combo box, this causes problems for Screen readers. The problem is that the user expects focus to remain in the text field so that the user can keep typing. If it moves to an item in the combobox list, it is not possible to keep typing
rdar://13093327
The solution I think is to not allow focus changes on aria-activedescendant changes for combo boxes. on the mac, we think we should send a selected children changed notification instead
Created attachment 185973 [details] patch
Comment on attachment 185973 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=185973&action=review > LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications.html:21 > + window.jsTestIsAsync = true; > + window.testRunner.waitUntilDone(); You don't need "window.". > LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt:2 > +item1 Could you hide this before the test finishes so that the expected result will have less noise? > LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt:9 > +PASS combo.isEqual(accessibilityController.focusedElement) is true > +PASS combo.isEqual(accessibilityController.focusedElement) is true It's not obvious to me what has been tested. It would have been better if comments in the tests were inside debug or they were wrapped in some inline functions, which are then called in evalAndLog.
(In reply to comment #4) > (From update of attachment 185973 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185973&action=review > > > LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications.html:21 > > + window.jsTestIsAsync = true; > > + window.testRunner.waitUntilDone(); > > You don't need "window.". > > > LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt:2 > > +item1 > > Could you hide this before the test finishes so that the expected result will have less noise? > > > LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt:9 > > +PASS combo.isEqual(accessibilityController.focusedElement) is true > > +PASS combo.isEqual(accessibilityController.focusedElement) is true > > It's not obvious to me what has been tested. It would have been better if comments in the tests were inside debug or they were wrapped in some inline functions, which are then called in evalAndLog. Thanks for the feedback. Will update these
http://trac.webkit.org/changeset/141560