Bug 108588 - [Gtk][WK2] Fix build after recent WebKit2 changes
Summary: [Gtk][WK2] Fix build after recent WebKit2 changes
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 525.x (Safari 3.2)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2013-01-31 23:42 PST by Seulgi Kim
Modified: 2013-02-01 04:56 PST (History)
5 users (show)

See Also:

Patch (3.44 KB, patch)
2013-01-31 23:58 PST, Seulgi Kim
no flags Details | Formatted Diff | Diff
Patch (2.73 KB, patch)
2013-02-01 01:38 PST, Seulgi Kim
no flags Details | Formatted Diff | Diff
Patch for landing (2.77 KB, patch)
2013-02-01 02:50 PST, Seulgi Kim
skyul: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Seulgi Kim 2013-01-31 23:42:12 PST
Do the same as https://bugs.webkit.org/show_bug.cgi?id=108548
Comment 1 Seulgi Kim 2013-01-31 23:58:47 PST
Created attachment 185958 [details]
Comment 2 EFL EWS Bot 2013-02-01 00:55:54 PST
Comment on attachment 185958 [details]

Attachment 185958 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16296476
Comment 3 Seulgi Kim 2013-02-01 01:38:45 PST
Created attachment 185976 [details]
Comment 4 Simon Hausmann 2013-02-01 02:36:15 PST
Patch looks pretty good, almost identical to the fix to WorkQueueQt.cpp in http://trac.webkit.org/changeset/141528/trunk/Source/WebKit2/Platform/qt/WorkQueueQt.cpp
Comment 5 WebKit Review Bot 2013-02-01 02:40:40 PST
Comment on attachment 185976 [details]

Rejecting attachment 185976 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 185976, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/16297605
Comment 6 Seulgi Kim 2013-02-01 02:50:37 PST
Created attachment 185998 [details]
Patch for landing
Comment 7 Simon Hausmann 2013-02-01 04:56:29 PST
Committed r141580: <http://trac.webkit.org/changeset/141580>