Bug 108571 - [css3-text] Add gap to TextDecorationStyleWavy's vertical position
Summary: [css3-text] Add gap to TextDecorationStyleWavy's vertical position
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 92868
  Show dependency treegraph
 
Reported: 2013-01-31 20:51 PST by Lamarque V. Souza
Modified: 2013-03-28 13:33 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.09 KB, patch)
2013-01-31 20:58 PST, Lamarque V. Souza
no flags Details | Formatted Diff | Diff
Screenshot of the change (4.33 KB, image/png)
2013-01-31 22:43 PST, Lamarque V. Souza
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lamarque V. Souza 2013-01-31 20:51:33 PST
Current wavy text decoration implementations [1] draw the wavy stroke too close to the text, adding a gap with the size of the stroke thickness can fix this problem. I will push a patch to fix just that.

[1] https://bugs.webkit.org/show_bug.cgi?id=92868
Comment 1 Lamarque V. Souza 2013-01-31 20:58:04 PST
Created attachment 185929 [details]
Patch

Proposed patch
Comment 2 Lamarque V. Souza 2013-01-31 22:43:45 PST
Created attachment 185949 [details]
Screenshot of the change
Comment 3 Benjamin Poulain 2013-02-01 13:57:13 PST
Comment on attachment 185929 [details]
Patch

Why no tests?
Comment 4 Lamarque V. Souza 2013-03-28 13:32:10 PDT
This patch was merged into the patch in https://bugs.webkit.org/show_bug.cgi?id=92868
Comment 5 Benjamin Poulain 2013-03-28 13:33:27 PDT
Comment on attachment 185929 [details]
Patch

Clearing the flags to remove the patch from the review queue.