Bug 108570 - [WK2] Use light supplement names instead of static AtomicStrings
Summary: [WK2] Use light supplement names instead of static AtomicStrings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-31 20:50 PST by Benjamin Poulain
Modified: 2013-02-01 16:11 PST (History)
5 users (show)

See Also:

Attachments
Patch (47.25 KB, patch)
2013-01-31 20:54 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-01-31 20:50:54 PST 
[WK2] Use light supplement names instead of static AtomicStrings
Comment 1 Benjamin Poulain 2013-01-31 20:54:17 PST 
Created attachment 185925 [details]
Patch
Comment 2 Anders Carlsson 2013-02-01 11:37:25 PST 
I like this!

How about we use the StringReference class instead - it's meant for storing a static string + length. It's currently inside the CoreIPC directory but we could move it out to Platform and use it for this as well (The advantage would be that we won't have to check string lengths).
Comment 3 Benjamin Poulain 2013-02-01 16:11:34 PST 
Comment on attachment 185925 [details]
Patch

Clearing flags on attachment: 185925

Committed r141658: <http://trac.webkit.org/changeset/141658>
Comment 4 Benjamin Poulain 2013-02-01 16:11:36 PST 
All reviewed patches have been landed.  Closing bug.