WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
108570
[WK2] Use light supplement names instead of static AtomicStrings
https://bugs.webkit.org/show_bug.cgi?id=108570
Summary
[WK2] Use light supplement names instead of static AtomicStrings
Benjamin Poulain
Reported
2013-01-31 20:50:54 PST
[WK2] Use light supplement names instead of static AtomicStrings
Attachments
Patch
(47.25 KB, patch)
2013-01-31 20:54 PST
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2013-01-31 20:54:17 PST
Created
attachment 185925
[details]
Patch
Anders Carlsson
Comment 2
2013-02-01 11:37:25 PST
I like this! How about we use the StringReference class instead - it's meant for storing a static string + length. It's currently inside the CoreIPC directory but we could move it out to Platform and use it for this as well (The advantage would be that we won't have to check string lengths).
Benjamin Poulain
Comment 3
2013-02-01 16:11:34 PST
Comment on
attachment 185925
[details]
Patch Clearing flags on attachment: 185925 Committed
r141658
: <
http://trac.webkit.org/changeset/141658
>
Benjamin Poulain
Comment 4
2013-02-01 16:11:36 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug