Bug 108569 - PrettyPatch/prettify.rb doesn't specify a load path for PrettyPatch.rb, & hard-codes the system ruby
Summary: PrettyPatch/prettify.rb doesn't specify a load path for PrettyPatch.rb, & har...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-31 20:44 PST by Nathan de Vries
Modified: 2013-02-01 14:47 PST (History)
3 users (show)

See Also:


Attachments
Adds the directory containing prettify.rb to the $LOAD_PATH, and uses `env` to determine the ruby executable to use. (1.71 KB, patch)
2013-01-31 20:56 PST, Nathan de Vries
no flags Details | Formatted Diff | Diff
Patch without the commented out $LOAD_PATH push. (1.71 KB, patch)
2013-01-31 21:08 PST, Nathan de Vries
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan de Vries 2013-01-31 20:44:05 PST
You should be able to run prettify.rb from any working directory, and it shouldn't hard-code the system ruby path.
Comment 1 Nathan de Vries 2013-01-31 20:56:26 PST
Created attachment 185926 [details]
Adds the directory containing prettify.rb to the $LOAD_PATH, and uses `env` to determine the ruby executable to use.
Comment 2 Joseph Pecoraro 2013-01-31 21:02:59 PST
Comment on attachment 185926 [details]
Adds the directory containing prettify.rb to the $LOAD_PATH, and uses `env` to determine the ruby executable to use.

View in context: https://bugs.webkit.org/attachment.cgi?id=185926&action=review

> Websites/bugs.webkit.org/PrettyPatch/prettify.rb:7
> +#$LOAD_PATH << Pathname.new(__FILE__).dirname.realpath.to_s

This looks commented out. Otherwise this looks good to me.
Comment 3 Nathan de Vries 2013-01-31 21:08:38 PST
Created attachment 185931 [details]
Patch without the commented out $LOAD_PATH push.
Comment 4 WebKit Review Bot 2013-01-31 22:20:07 PST
Comment on attachment 185931 [details]
Patch without the commented out $LOAD_PATH push.

Attachment 185931 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16296320

New failing tests:
fast/forms/datalist/update-range-with-datalist.html
fast/layers/no-clipping-overflow-hidden-added-after-transform.html
inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html
fast/loader/text-document-wrapping.html
fast/loader/javascript-url-in-object.html
fast/layers/no-clipping-overflow-hidden-added-after-transition.html
fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html
Comment 5 Joseph Pecoraro 2013-02-01 13:49:49 PST
Comment on attachment 185931 [details]
Patch without the commented out $LOAD_PATH push.

r=me, test failures are unrelated
Comment 6 WebKit Review Bot 2013-02-01 14:47:49 PST
Comment on attachment 185931 [details]
Patch without the commented out $LOAD_PATH push.

Clearing flags on attachment: 185931

Committed r141646: <http://trac.webkit.org/changeset/141646>
Comment 7 WebKit Review Bot 2013-02-01 14:47:53 PST
All reviewed patches have been landed.  Closing bug.