I don't see any suspicious change http://trac.webkit.org/log/?verbose=on&rev=141496&stop_rev=141491 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-key-operations.html Seeing the failing test is named testToday(), my wild guess is that this might be a cross-month bug. But I'm not confident about that.
Marked http://trac.webkit.org/changeset/141527
> function testToday() { > eventSender.keyDown('t'); > var now = new Date(); > var expectedDate = serializeDate(now.getFullYear(), now.getMonth(), now.getDate()); > var expectedMonth = popupWindow.Month.createFromDate(now).toString(); > return selectedDate() === expectedDate && currentMonth() === expectedMonth; > } There is a timezone mismatch. createFromDate() expects that the input represents a date in UTC. So, the test started failing since January ended in UTC but it's still January in PST.
The test passed again because It became February in PST. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=calendar-picker-key-operations.html
(In reply to comment #3) > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=calendar-picker-key-operations.html OK, I'll unskip it. Thanks for the reminder!
Created attachment 185978 [details] Patch
Comment on attachment 185978 [details] Patch Just for closing this bug...
Comment on attachment 185978 [details] Patch No, we should fix the test bug.
(In reply to comment #7) > No, we should fix the test bug. Well, right.
Created attachment 185988 [details] Patch
Comment on attachment 185988 [details] Patch LGTM
Created attachment 186270 [details] Patch 3 resolve conflict
Comment on attachment 186270 [details] Patch 3 Clearing flags on attachment: 186270 Committed r141722: <http://trac.webkit.org/changeset/141722>
All reviewed patches have been landed. Closing bug.