Bug 108566 – calendar-picker-key-operations.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Hajime Morrita]

I don't see any suspicious change

http://trac.webkit.org/log/?verbose=on&rev=141496&stop_rev=141491
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-key-operations.html

Seeing the failing test is named testToday(), my wild guess is that this might be a cross-month bug.
But I'm not confident about that.

[Hajime Morrita]

Marked http://trac.webkit.org/changeset/141527

[Kent Tamura]

> function testToday() {
>     eventSender.keyDown('t');
>     var now = new Date();
>     var expectedDate = serializeDate(now.getFullYear(), now.getMonth(), now.getDate());
>     var expectedMonth = popupWindow.Month.createFromDate(now).toString();
>     return selectedDate() === expectedDate && currentMonth() === expectedMonth;
> }

There is a timezone mismatch.  createFromDate() expects that the input represents a date in UTC.  So, the test started failing since January ended in UTC but it's still January in PST.

[Kent Tamura]

The test passed again because It became February in PST.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=calendar-picker-key-operations.html

[Hajime Morrita]

(In reply to comment #3)
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=calendar-picker-key-operations.html

OK, I'll unskip it. Thanks for the reminder!

[Hajime Morrita]

Created attachment 185978 [details]
Patch

[Hajime Morrita]

Comment on attachment 185978 [details]
Patch

Just for closing this bug...

[Kent Tamura]

Comment on attachment 185978 [details]
Patch

No, we should fix the test bug.

[Hajime Morrita]

(In reply to comment #7)
> No, we should fix the test bug.
Well, right.

[Kent Tamura]

Created attachment 185988 [details]
Patch

[Kentaro Hara]

Comment on attachment 185988 [details]
Patch

LGTM

[Kent Tamura]

Created attachment 186270 [details]
Patch 3

resolve conflict

[WebKit Review Bot]

Comment on attachment 186270 [details]
Patch 3

Clearing flags on attachment: 186270

Committed r141722: <http://trac.webkit.org/changeset/141722>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.