NEW108552
allow using unattached canvas for drag icon. 
https://bugs.webkit.org/show_bug.cgi?id=108552
Summary allow using unattached canvas for drag icon.
arno.
Reported 2013-01-31 17:02:49 PST
Hi, currently, it's possible to set a custom image for drag and drop (with dataTransfer.setDragImage) We can use a random element, it will be used as an image "as rendered on the document". There is special case for an unattached image. It would be nice to be able to use unattached canvas also.
Attachments
patch proposal (35.94 KB, patch)
2013-02-01 12:43 PST, arno. 		no flags
DetailsFormatted DiffDiff
updated patch: fixes windows build failure (35.95 KB, patch)
2013-02-01 15:42 PST, arno. 		no flags
DetailsFormatted DiffDiff
update patch against current trunk (32.90 KB, patch)
2013-03-22 12:30 PDT, arno. 		no flags
DetailsFormatted DiffDiff
updated patch against current trunk (24.64 KB, patch)
2013-05-04 14:53 PDT, arno. 		no flags
DetailsFormatted DiffDiff
updated patch: fixes qt build failure (24.44 KB, patch)
2013-05-04 19:03 PDT, arno. 		beidson: review-
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
arno.
Comment 1 2013-02-01 12:43:13 PST
Created attachment 186108 [details] patch proposal
Build Bot
Comment 2 2013-02-01 15:24:35 PST
Comment on attachment 186108 [details] patch proposal Attachment 186108 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16337233
arno.
Comment 3 2013-02-01 15:42:11 PST
Created attachment 186171 [details] updated patch: fixes windows build failure
Darin Adler
Comment 4 2013-02-01 16:01:14 PST
Comment on attachment 186171 [details] updated patch: fixes windows build failure View in context: https://bugs.webkit.org/attachment.cgi?id=186171&action=review > Source/WebCore/ChangeLog:9 > + Since currently, no port implements CachedImageClient for the > + clipboard, replace the use of a CachedImage by an Image in Clipboard. What do you mean, no port? Mac does.
arno.
Comment 5 2013-02-01 16:07:59 PST
(In reply to comment #4) > (From update of attachment 186171 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186171&action=review > > > Source/WebCore/ChangeLog:9 > > + Since currently, no port implements CachedImageClient for the > > + clipboard, replace the use of a CachedImage by an Image in Clipboard. > > What do you mean, no port? Mac does. I could not find the implementation of CachedImageClient methods for the clipboard: imageChanged, willRenderImage, didReceiveData, notifyFinished. It looks like the default one (which are noop methods) are used.
arno.
Comment 6 2013-03-22 12:30:48 PDT
Created attachment 194617 [details] update patch against current trunk
arno.
Comment 7 2013-05-04 14:53:40 PDT
Created attachment 200545 [details] updated patch against current trunk
Early Warning System Bot
Comment 8 2013-05-04 15:05:37 PDT
Comment on attachment 200545 [details] updated patch against current trunk Attachment 200545 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/401474
Early Warning System Bot
Comment 9 2013-05-04 15:09:33 PDT
Comment on attachment 200545 [details] updated patch against current trunk Attachment 200545 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/392824
arno.
Comment 10 2013-05-04 19:03:53 PDT
Created attachment 200584 [details] updated patch: fixes qt build failure
Brady Eidson
Comment 11 2016-05-24 21:38:13 PDT
Comment on attachment 200584 [details] updated patch: fixes qt build failure r- to clear stale patches from the review queue
Note You need to log in before you can comment on or make changes to this bug.