RESOLVED FIXED 108544
WorkQueue should be a ref-counted class 
https://bugs.webkit.org/show_bug.cgi?id=108544
Summary WorkQueue should be a ref-counted class
Anders Carlsson
Reported 2013-01-31 15:35:33 PST
WorkQueue should be a ref-counted class
Attachments
Patch (17.02 KB, patch)
2013-01-31 15:39 PST, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-01-31 15:39:42 PST
Created attachment 185882 [details] Patch
WebKit Review Bot
Comment 2 2013-01-31 15:42:56 PST
Attachment 185882 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/Connection.cpp', u'Source/WebKit2/Platform/CoreIPC/Connection.h', u'Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp', u'Source/WebKit2/Platform/WorkQueue.cpp', u'Source/WebKit2/Platform/WorkQueue.h', u'Source/WebKit2/Platform/mac/WorkQueueMac.cpp', u'Source/WebKit2/Shared/ChildProcess.cpp', u'Source/WebKit2/UIProcess/Launcher/ProcessLauncher.cpp', u'Source/WebKit2/UIProcess/WebProcessProxy.cpp']" exit_code: 1 Source/WebKit2/Platform/mac/WorkQueueMac.cpp:34: Missing space before { [whitespace/braces] [5] Source/WebKit2/Platform/mac/WorkQueueMac.cpp:47: Missing space before { [whitespace/braces] [5] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2013-01-31 15:44:48 PST
Committed r141497: <http://trac.webkit.org/changeset/141497>
Note You need to log in before you can comment on or make changes to this bug.