Bug 108539 - Assert that computePreferredLogicalWidths never calls setNeedsLayout
Summary: Assert that computePreferredLogicalWidths never calls setNeedsLayout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-31 15:13 PST by Ojan Vafai
Modified: 2013-01-31 17:49 PST (History)
8 users (show)

See Also:


Attachments
Patch (8.63 KB, patch)
2013-01-31 15:13 PST, Ojan Vafai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2013-01-31 15:13:03 PST
Assert that computePreferredLogicalWidths never calls setNeedsLayout
Comment 1 Ojan Vafai 2013-01-31 15:13:56 PST
Created attachment 185876 [details]
Patch
Comment 2 Tony Chang 2013-01-31 16:20:48 PST
Comment on attachment 185876 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185876&action=review

> Source/WebCore/ChangeLog:11
> +        This is take 2 after this was rolled out because it was missing the guards
> +        in RenderCounter/RenderQuote.

What happened to the original bug?  Should this patch be attached there?
Comment 3 Ojan Vafai 2013-01-31 16:37:46 PST
(In reply to comment #2) 
> What happened to the original bug?  Should this patch be attached there?

I guess so in retrospect since that got rolled out. I'll put a link to this bug in that one.
Comment 4 WebKit Review Bot 2013-01-31 17:49:53 PST
Comment on attachment 185876 [details]
Patch

Clearing flags on attachment: 185876

Committed r141517: <http://trac.webkit.org/changeset/141517>
Comment 5 WebKit Review Bot 2013-01-31 17:49:57 PST
All reviewed patches have been landed.  Closing bug.