RESOLVED FIXED 108514
Get rid of IncomingMessage 
https://bugs.webkit.org/show_bug.cgi?id=108514
Summary Get rid of IncomingMessage
Anders Carlsson
Reported 2013-01-31 12:30:56 PST
Get rid of IncomingMessage
Attachments
Patch (13.50 KB, patch)
2013-01-31 12:31 PST, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-01-31 12:31:39 PST
Created attachment 185838 [details] Patch
Sam Weinig
Comment 2 2013-01-31 12:40:24 PST
Comment on attachment 185838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185838&action=review > Source/WebKit2/Platform/CoreIPC/Connection.cpp:92 > + // FIXME: This should really an be OwnPtr, > + // but we need Vector to work with move semantics first. The bug here is https://bugs.webkit.org/show_bug.cgi?id=87594. But, is this really true. Can't you use VectorTraits? Vector already knows how to work with OwnPtr for instance.
Anders Carlsson
Comment 3 2013-01-31 12:41:33 PST
(In reply to comment #2) > (From update of attachment 185838 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185838&action=review > > > Source/WebKit2/Platform/CoreIPC/Connection.cpp:92 > > + // FIXME: This should really an be OwnPtr, > > + // but we need Vector to work with move semantics first. > > The bug here is https://bugs.webkit.org/show_bug.cgi?id=87594. But, is this really true. Can't you use VectorTraits? Vector already knows how to work with OwnPtr for instance. I can't use VectorTraits because that there's still copying involved when passing the struct to Vector::append.
Sam Weinig
Comment 4 2013-01-31 12:42:11 PST
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 185838 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=185838&action=review > > > > > Source/WebKit2/Platform/CoreIPC/Connection.cpp:92 > > > + // FIXME: This should really an be OwnPtr, > > > + // but we need Vector to work with move semantics first. > > > > The bug here is https://bugs.webkit.org/show_bug.cgi?id=87594. But, is this really true. Can't you use VectorTraits? Vector already knows how to work with OwnPtr for instance. > > I can't use VectorTraits because that there's still copying involved when passing the struct to Vector::append. I see.
Anders Carlsson
Comment 5 2013-01-31 12:48:39 PST
Committed r141465: <http://trac.webkit.org/changeset/141465>
Note You need to log in before you can comment on or make changes to this bug.