Bug 108490 – Use ASSERT_WITH_SECURITY_IMPLICATION to catch bad casts in DOM

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Abhishek Arya]

We have found numerous bugs (>12) after patch in http://trac.webkit.org/changeset/140640. This is another patch in sequence for dom nodes, css stuff.

[Oliver Hunt]

Can we get a bug that tracks all the bugs found by ASSERT_WITH_SECURITY_IMPLICATION?

[Abhishek Arya]

(In reply to comment #1)
> Can we get a bug that tracks all the bugs found by ASSERT_WITH_SECURITY_IMPLICATION?

Ok, starting to add "Depends on 107699" on those bugs. note that some bugs are filed in chromium repo are not upstreamed yet, i will do that in a day or two, just came back from a vacation :)

[Abhishek Arya]

Created attachment 185865 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 185865 [details]
Patch

OK.

[Eric Seidel (no email)]

Have you documented in Assertions.h where/when these should be used?  It's important that we do that so that other developers are not confused. :)

[WebKit Review Bot]

Comment on attachment 185865 [details]
Patch

Clearing flags on attachment: 185865

Committed r141516: <http://trac.webkit.org/changeset/141516>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Abhishek Arya]

(In reply to comment #5)
> Have you documented in Assertions.h where/when these should be used?  It's important that we do that so that other developers are not confused. :)

Yes, there is a comment in there explaining the meaning and use of the assert. I plan to expand on the comment soon.