Bug 108490 - Use ASSERT_WITH_SECURITY_IMPLICATION to catch bad casts in DOM
Summary: Use ASSERT_WITH_SECURITY_IMPLICATION to catch bad casts in DOM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-31 09:10 PST by Abhishek Arya
Modified: 2013-02-01 08:19 PST (History)
19 users (show)

See Also:

Attachments
Patch (18.99 KB, patch)
2013-01-31 14:25 PST, Abhishek Arya 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Abhishek Arya 2013-01-31 09:10:18 PST 
We have found numerous bugs (>12) after patch in http://trac.webkit.org/changeset/140640. This is another patch in sequence for dom nodes, css stuff.
Comment 1 Oliver Hunt 2013-01-31 10:46:30 PST 
Can we get a bug that tracks all the bugs found by ASSERT_WITH_SECURITY_IMPLICATION?
Comment 2 Abhishek Arya 2013-01-31 10:58:39 PST 
(In reply to comment #1)
> Can we get a bug that tracks all the bugs found by ASSERT_WITH_SECURITY_IMPLICATION?

Ok, starting to add "Depends on 107699" on those bugs. note that some bugs are filed in chromium repo are not upstreamed yet, i will do that in a day or two, just came back from a vacation :)
Comment 3 Abhishek Arya 2013-01-31 14:25:48 PST 
Created attachment 185865 [details]
Patch
Comment 4 Eric Seidel (no email) 2013-01-31 16:11:46 PST 
Comment on attachment 185865 [details]
Patch

OK.
Comment 5 Eric Seidel (no email) 2013-01-31 16:12:14 PST 
Have you documented in Assertions.h where/when these should be used?  It's important that we do that so that other developers are not confused. :)
Comment 6 WebKit Review Bot 2013-01-31 17:41:04 PST 
Comment on attachment 185865 [details]
Patch

Clearing flags on attachment: 185865

Committed r141516: <http://trac.webkit.org/changeset/141516>
Comment 7 WebKit Review Bot 2013-01-31 17:41:09 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Abhishek Arya 2013-02-01 08:19:38 PST 
(In reply to comment #5)
> Have you documented in Assertions.h where/when these should be used?  It's important that we do that so that other developers are not confused. :)

Yes, there is a comment in there explaining the meaning and use of the assert. I plan to expand on the comment soon.