In the fairly mechanical patch for https://bugs.webkit.org/show_bug.cgi?id=108476, I touched WebKit2 code without noticing. It would be a good idea, I think, if the watchlist would note the necessity of owners approval in the same way that it currently does for the Chromium public API. I've suggested "Please wait for approval from a member of the WebKit2 OWNERS filebefore submitting this patch, as it contains changes to WebKit2.", but I'm of course happy to change the wording to whatever the WebKit2 team would prefer. :)
Created attachment 185792 [details] Patch
Created attachment 185793 [details] Whitespace, my old nemesis.
Comment on attachment 185793 [details] Whitespace, my old nemesis. View in context: https://bugs.webkit.org/attachment.cgi?id=185793&action=review > Tools/Scripts/webkitpy/common/config/watchlist:461 > + "WebKit2OWNERS": [ "Please wait for approval from a member of the WebKit2 OWNERS file " > + "before submitting this patch, as it contains changes to WebKit2.", ], http://trac.webkit.org/browser/trunk/Source/WebKit2/Owners <--- Note that it's "Owners" rather than "OWNERS".
(In reply to comment #3) > (From update of attachment 185793 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185793&action=review > > > Tools/Scripts/webkitpy/common/config/watchlist:461 > > + "WebKit2OWNERS": [ "Please wait for approval from a member of the WebKit2 OWNERS file " > > + "before submitting this patch, as it contains changes to WebKit2.", ], > > http://trac.webkit.org/browser/trunk/Source/WebKit2/Owners <--- Note that it's "Owners" rather than "OWNERS". I'll fix that, thanks for the review. I'd appreciate someone on the Owners list weighing in here before I land this, however, since it affects how the change in process is presented to developers. I think the text is uncontroversial, but I'd like confirmation of that. :)