Bug 108478 - Web Inspector: show cursor location in DTE
Summary: Web Inspector: show cursor location in DTE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-31 06:48 PST by Andrey Lushnikov
Modified: 2013-01-31 09:19 PST (History)
9 users (show)

See Also:

Attachments
Patch (5.33 KB, patch)
2013-01-31 06:56 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (5.47 KB, patch)
2013-01-31 07:11 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
selection-multiline (23.22 KB, image/png)
2013-01-31 07:11 PST, Andrey Lushnikov 		no flags Details
selection of one line (20.65 KB, image/png)
2013-01-31 07:11 PST, Andrey Lushnikov 		no flags Details
cursor coordinates (19.14 KB, image/png)
2013-01-31 07:12 PST, Andrey Lushnikov 		no flags Details
Patch (7.27 KB, patch)
2013-01-31 08:13 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-01-31 06:48:48 PST 
Show cursor location in DefaultTextEditor.
Comment 1 Andrey Lushnikov 2013-01-31 06:56:15 PST 
Created attachment 185773 [details]
Patch
Comment 2 Pavel Feldman 2013-01-31 07:01:08 PST 
Comment on attachment 185773 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185773&action=review

> Source/WebCore/inspector/front-end/SourceFrame.js:66
> +    this._sourcePositionElement.addStyleClass("source-position");

.className = "source-frame-position"

> Source/WebCore/inspector/front-end/SourceFrame.js:640
> +            this._sourcePositionElement.textContent = "Line " + (textRange.endLine + 1) + ", Column " + (textRange.endColumn + 1);

= WebInspector.UIString("Line %d, Column %d, line, column);

> Source/WebCore/inspector/front-end/SourceFrame.js:647
> +            text = (textRange.endLine - textRange.startLine + 1) + " lines, " + text;

ditto
Comment 3 Andrey Lushnikov 2013-01-31 07:11:06 PST 
Created attachment 185776 [details]
Patch
Comment 4 Andrey Lushnikov 2013-01-31 07:11:34 PST 
Created attachment 185777 [details]
selection-multiline
Comment 5 Andrey Lushnikov 2013-01-31 07:11:56 PST 
Created attachment 185778 [details]
selection of one line
Comment 6 Andrey Lushnikov 2013-01-31 07:12:21 PST 
Created attachment 185779 [details]
cursor coordinates
Comment 7 Pavel Feldman 2013-01-31 08:05:36 PST 
Comment on attachment 185776 [details]
Patch

Add them to localizedStrings.js
Comment 8 Andrey Lushnikov 2013-01-31 08:13:19 PST 
Created attachment 185787 [details]
Patch
Comment 9 WebKit Review Bot 2013-01-31 09:19:03 PST 
Comment on attachment 185787 [details]
Patch

Clearing flags on attachment: 185787

Committed r141426: <http://trac.webkit.org/changeset/141426>
Comment 10 WebKit Review Bot 2013-01-31 09:19:07 PST 
All reviewed patches have been landed.  Closing bug.